Skip to content

Conversation

ciband
Copy link
Contributor

@ciband ciband commented Feb 19, 2019

Proposed changes

This change fixes the currently broken PIO CI builds by correcting the submodules ignore paths in the PIO INI file.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Build (changes that affect the build system)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

Further comments

N/A

@ghost
Copy link

ghost commented Feb 19, 2019

@ciband Thanks for submitting this pull request, a maintainer will get back to you shortly!

@ghost
Copy link

ghost commented Feb 19, 2019

@air1one @faustbrian - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost requested a review from air1one February 19, 2019 02:37
@ghost ghost added the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Feb 19, 2019
@ghost
Copy link

ghost commented Feb 19, 2019

@ciband Your pull request doesn't follow our contribution guidelines. Please review and correct it.

@ghost ghost added the Complexity: Low Less than 64 lines changed. label Feb 19, 2019
@faustbrian faustbrian added the Bounty: Tier 5 Awarded for minor features, refactorings, improvements. This is valued at 0 USD. label Feb 19, 2019
@ghost
Copy link

ghost commented Feb 19, 2019

@ciband A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@ghost ghost added the Status: Contributor Approved The pull request has been approved by a contributor. label Feb 19, 2019
@faustbrian faustbrian merged commit 65d96d5 into ArkEcosystemArchive:master Feb 19, 2019
@ghost
Copy link

ghost commented Feb 19, 2019

@ciband Your pull request has been merged and marked as tier 5. It will earn you $5 USD.

@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bounty: Tier 5 Awarded for minor features, refactorings, improvements. This is valued at 0 USD. Complexity: Low Less than 64 lines changed. Status: Contributor Approved The pull request has been approved by a contributor.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants