[PPSC-853] fix(install): correct Gemini CLI hook timeout unit#204
Merged
Conversation
Gemini CLI expects timeout in milliseconds. The hook was configured with 10 (10ms), causing it to time out before the Python script could start. Changed to 10000 (10 seconds).
|
There was a problem hiding this comment.
Pull request overview
Fixes a Gemini CLI hook timeout that was set to 10 (ms), causing the security scan hook to be skipped before it could run. Changed to 10000 (10s) to match the intended behavior.
Changes:
- Updated
timeoutvalue inbuildGeminiHooksfrom10to10000.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Test Coverage Reporttotal: (statements) 71.7% Coverage by function |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Type of Change
Problem
The Gemini CLI hook timeout was set to
10in~/.gemini/settings.json. Gemini CLI interprets this value in milliseconds, so the hook was timing out after 10ms — before the Python security scanning script could even start — causing it to be silently skipped.Solution
Changed the timeout from
10to10000(10 seconds), matching the intended behavior of other client hook configurations.Testing
Automated Tests
go test ./internal/install/...)Manual Testing
Verified the generated
settings.jsonnow contains"timeout": 10000.Checklist