Add HTTP proxy support via environment variables#29
Merged
Conversation
shaiarmis
reviewed
May 28, 2025
shaiarmis
reviewed
May 28, 2025
shaiarmis
reviewed
May 28, 2025
shaiarmis
reviewed
May 28, 2025
Comment on lines
+105
to
+107
| proxy = self._get_proxy_config() | ||
|
|
||
| if proxy: |
Collaborator
There was a problem hiding this comment.
Suggested change
| proxy = self._get_proxy_config() | |
| if proxy: | |
| if proxy := self._get_proxy_config(): |
shaiarmis
reviewed
May 28, 2025
shaiarmis
reviewed
May 28, 2025
shaiarmis
reviewed
May 28, 2025
|
|
||
| async with armis_client.client() as client: | ||
| assert ( | ||
| client._trust_env is True |
Collaborator
There was a problem hiding this comment.
Don't access private members
shaiarmis
reviewed
May 28, 2025
Collaborator
|
shaiarmis
approved these changes
Jun 2, 2025
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| "env_var,proxy_url, expected_proxy", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "env_var,proxy_url, expected_proxy", | |
| ["env_var", "proxy_url", "expected_proxy"], |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatically detects and uses HTTPS_PROXY/HTTP_PROXY environment variables