Added ability to set a time override on a per-query basis. #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrandonArp
reviewed
Nov 21, 2018
| return rval; | ||
| } | ||
|
|
||
| public static startTime(target: KairosDBTarget): number { |
Member
There was a problem hiding this comment.
Why are these methods static?
vjkoskela
reviewed
Nov 26, 2018
| "chai": "^4.1.2", | ||
| "es6-shim": "^0.35.3", | ||
| "grafana-sdk-mocks": "github:grafana/grafana-sdk-mocks", | ||
| "grafana-sdk-mocks": "github:briangann/grafana-sdk-mocks", |
Member
There was a problem hiding this comment.
I assume this is because we're blocked an PR from this fork? Can you file an issue for this project and link to that PR or change (if there is no PR back to origin).
BrandonArp
approved these changes
Dec 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls in the UI from the grafana timepicker in the upper left to allow specifying an time range override on a per-query basis. 'Time Range' now appears in the query builder with a + next to it to add an override, if one is present then it is displayed with a textual description of the override and a x next to it to remove the override. If an override is present then it would be sent in the query to kairos as a start_absolute/end_absolute for the QueryMetric object.