Fix up Post-Seath Arena entrance logic#61
Merged
ArsonAssassin merged 1 commit intoArsonAssassin:mainfrom Dec 6, 2025
Merged
Conversation
While First Arena after Seath's Death is physically connected to Duke's Archives, imo it more logically comes from Crystal Cave after Seath is defeated. This won't actually effect the logic, because the Event is in Crystal Cave, but I'm simplifying it to make it simpler to read (and to help keep the PopTracker pack up to date).
Owner
|
I think when i originally did this, i was lazy with the logic and considered all of crystal caves part of Dukes Archives. When dank_santa helped out, i think he renamed a bunch of them, this probably just fell through the cracks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While First Arena after Seath's Death is physically connected to Duke's Archives, imo it more logically comes from Crystal Cave after Seath is defeated.
This won't actually effect the logic, because the Event is in Crystal Cave, but I'm simplifying it to make it simpler to read (and to help keep the PopTracker pack up to date).