Домашнее задание 2го спринта #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kekulta
reviewed
Nov 18, 2024
Comment on lines
+1
to
+8
| public class Car { | ||
| String carName; | ||
| int carSpeed; | ||
| Car (String carName, int carSpeed) { | ||
| this.carName = carName; | ||
| this.carSpeed = carSpeed; | ||
| } | ||
| } |
There was a problem hiding this comment.
В Джаве принято делать поля приватными и писать для них геттеры и сеттеры.
Comment on lines
+10
to
+26
| System.out.println("Введите скорость машины первого участника (это должно быть число больше 0 и меньше или равно 250):"); | ||
| String inputCarSpeed = userInput.nextLine(); | ||
| int carSpeed = inputCarSpeedToInt(inputCarSpeed); | ||
| Car firstCar = new Car(carName, carSpeed); | ||
| Race race = new Race(); | ||
| race.whoIsWinner(firstCar); | ||
| System.out.println("Введите название машины второго участника:"); | ||
| carName = userInput.nextLine(); | ||
| System.out.println("Введите скорость машины второго участника (это должно быть число больше 0 и меньше или равно 250):"); | ||
| inputCarSpeed = userInput.nextLine(); | ||
| carSpeed = inputCarSpeedToInt(inputCarSpeed); | ||
| Car secondCar = new Car(carName, carSpeed); | ||
| race.whoIsWinner(secondCar); | ||
| System.out.println("Введите название машины третьего участника:"); | ||
| carName = userInput.nextLine(); | ||
| System.out.println("Введите скорость машины третьего участника (это должно быть число больше 0 и меньше или равно 250):"); | ||
| inputCarSpeed = userInput.nextLine(); |
There was a problem hiding this comment.
Правильнее было бы сделать это в цикле
Comment on lines
+45
to
+50
| } catch (NumberFormatException e) { | ||
| System.out.println("Неверно введена скорость! Введите число больше 0 и меньше или равной 250!"); | ||
| Scanner userInputSpeed = new Scanner(System.in); | ||
| inputSpeed = userInputSpeed.nextLine(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Молодец, что сразу отловил исключение!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Домашнее задание от Артура Сафиуллина проект гонка Ле Ман.
Студент курса по Android-разработке. Когорта №27