Skip to content

Permission othersBalance was never checked #2

@sinux-l5d

Description

@sinux-l5d

Hello,
I'm running a server for some friends and I noticed that even if I didn't give them the permission, they could get the account balance of others.
Here is a piece of my config.yml :

enable-logging: false

permissions:
  README: >
    IF YOU WANT THE PLUGIN TO USE PERMISSIONS,
    WRITE THE PERMISSIONS DOWN IN THE "".
    EMPTY QUOTATION MARKS => BALANCE AND OTHERSBALANCE AND PAY FOR EVERYONE
    AND MODIFY FOR OP ONLY
  balance: "ec.balance.self"
  othersBalance: "ec.balance.other"
  pay: "ec.pay"
  modify: "ec.modify"

And a piece of my bPermission config :

default: default
groups:
  default:
    permissions:
    - ec.balance.self
    - ^ec.balance.other
    - ec.pay

I noticed that in src/main/java/dev/wwst/easyconomy/commands/BalanceCommand.java, you check if the player has permissions.balance but never permissions.othersBalance.

I would have liked to fix it myself, but I'm still learning Java and I don't know where to find the librairies to compile your code.

I'm right here if you need further informations :)

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions