-
Notifications
You must be signed in to change notification settings - Fork 8
Testing against multiple solutions and multiple input/output-pairs #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'll have a look after work @Arxcis :) |
2961930 to
53fc954
Compare
53fc954 to
ed795ba
Compare
cca54c1 to
e07e3bd
Compare
…me time" This reverts commit e07e3bd.
|
@Arxcis sorry I got hung up doing aoc with a friend over discord, and then I hit my head against the wall with lisp for a while.. I don't know when I'll have time to take a proper look at this. I have a suggestion, but I don't feel comfortable giving it until I've tried to look for myself how it will work in practice. (Btw behold my creation: A precursor to how I want to do day 1 in Lisp) |
|
@tholok97 No worries. I have the feeling, I am going to need a few days to settle on something myself. This PR is not currently building in the CI, so you can hold off reviewing, until I have at least figured that one out. We can do the review/discussion/grooming in IRL if you like 😉 The good thing with this PR, is that we will eventually have something to look at while discussing . |
fix Conflicts: days/day-03/test.sh days/day-08/test.sh
|
You know what. I got a breakthrough. The tests are passing, and I am happy with how the new architecture works. I am comfortable with setting this to "Ready for review" now, as I am going to bed 🛏️ 😴 |
|
I got a really good review from @tholok97 IRL 😄 Thank you very much! 🙏 I will take all the things into consideration when making a decision on what to do tonight. |
Fix Conflicts: days/day-09/test.sh
fix Conflicts: days/day-09/input.txt days/day-09/output.txt
7fc0afb to
c3dceba
Compare
fix Conflicts: days/day-04/test.sh days/day-05/test.sh
Stektpotet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I saw, only a couple of minor things need to/can be "fixed" here.
As a whole, nice merge 👍
| ``` | ||
|
|
||
| 7. When you are happy with local testing, make a Pull Request to the `main` branch. | ||
| 8. One of the maintainers will merge PR's, at the of each day. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the maintainers will merge PR's, at the ................. of each day.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀 Well spotted. Since I already merged, I will commit a fix for this directly 👍
| # $DAY | ||
| ## --- Part 1 --- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure most of the readme fiiles we have so far have these two combined.
It could be changed to this:
# --- $DAY: Title ---
Not that that really matters in the template, as it's going to be written over at some point again...
¯\_(ツ)_/¯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it matters, even if it is a minor thing, because the template is supposed to help the developer. It is a way of documenting things, and communicating intent, so that any contributor is capable of contributing README.md's. I will fix in a commit directly. 👍
|
Thank you for reviewing @Stektpotet 🙏 |

TLDR;
A lot of stuff is changing, but the repo will still be familiar to you 👍

Why?
Make it possible for everyone to submit their own input, without worrying about getting conflicts with others.
It is helpful to test against multiple distinct input/output-pairs, to make sure our solutions are robust - does not make assumptions about a specific input/output-files being provided.
Suggested change
Change the signature of the language-tests to take a list of
SOLUTION_FILESand a list ofIO_FILESas input:Example declaration in
languages/go.shExample usage in
days/day-05/test.shExample running
./days/day-05/test.sh