Skip to content

returns rental vehicles#635

Merged
DomT602 merged 8 commits intoAsYetUntitled:masterfrom
that-edward:returnRental
Mar 25, 2020
Merged

returns rental vehicles#635
DomT602 merged 8 commits intoAsYetUntitled:masterfrom
that-edward:returnRental

Conversation

@that-edward
Copy link
Copy Markdown
Contributor

Changes proposed in this pull request:

  • Returns rental vehicles, so people don't leave them out and about as they can't return them to the garage. Doesn't put them in their garage, just deletes the vehicle.

  • I have tested my changes and corrected any errors found

@AsYetUntitled AsYetUntitled deleted a comment from that-edward Mar 24, 2020
@AsYetUntitled AsYetUntitled deleted a comment from that-edward Mar 24, 2020
Copy link
Copy Markdown
Member

@DomT602 DomT602 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks for the PR.

Copy link
Copy Markdown
Member

@DomT602 DomT602 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussion, could this be made into a toggleable option in Config_Master so server owners can turn of/off this setting.

@that-edward
Copy link
Copy Markdown
Contributor Author

Something like this @DomT602 ?

Copy link
Copy Markdown
Member

@DomT602 DomT602 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@DomT602 DomT602 added the 6.0.0 label Mar 25, 2020
@DomT602 DomT602 merged commit 3e36b49 into AsYetUntitled:master Mar 25, 2020
@that-edward that-edward deleted the returnRental branch June 6, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants