-
Notifications
You must be signed in to change notification settings - Fork 311
blastingChargeFix #694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blastingChargeFix #694
Conversation
Fixes AsYetUntitled#690 by checking whether the bomb gets defused each frame
DomT602
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some thoughts
DomT602
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with the changes
ghost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to use LIFE_SETTINGS in fn_handleBlastingCharge.sqf it requires include of script_macros.hpp
|
@shazoo-o good spot - have you by chance tested it with macros in the file? |
I noticed this problem as I had merged this in my repo and tried to start the server - which failed with an error message around the LIFE_SETTINGS macro. I then just added the include line and it worked. |
DomT602
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just made a couple of formatting changes for better information and readability.
Resolves #690
Changes proposed in this pull request:
Checks whether the bomb gets defused on each frame, and if the bomb gets defused it exits the
waitUntilloop and thus checks whether the bomb is placed (which it is not), so it exits the function.I have tested my changes and corrected any errors found
EDIT: Typo