Skip to content

Commit 7973168

Browse files
jannausvenpeter42
authored andcommitted
arm64: dts: apple: Fix style issues for t600x multi die .dtsi
The M1 Pro/Max/Ultra .dtsi files containing most MMIO nodes are a collection of nodes without parent. The proper embedding inside a "simple-bus" parent only happens in t6001.dtsi and t6002.dtsi. Fix these dt style issue by using a define for their parent soc node and bracket those MMIO nodes inside it. Link: https://lore.kernel.org/asahi/e2365307-32d6-4ef9-9919-55ba69786741@kernel.org/ Suggested-by: Krzysztof Kozlowski <krzk@kernel.org> Signed-off-by: Janne Grunau <j@jannau.net> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> Link: https://patch.msgid.link/20260903-apple-soc-multi-die-style-v1-1-eeb05ea0c187@jannau.net Signed-off-by: Sven Peter <sven@kernel.org>
1 parent ea3cef7 commit 7973168

5 files changed

Lines changed: 19 additions & 17 deletions

File tree

arch/arm64/boot/dts/apple/t6001.dtsi

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,18 +35,17 @@
3535

3636
#define DIE
3737
#define DIE_NO 0
38+
#define SOC_NODE {/soc}
3839

39-
&{/soc} {
40-
#include "t600x-die0.dtsi"
41-
#include "t600x-dieX.dtsi"
42-
#include "t600x-nvme.dtsi"
43-
};
44-
40+
#include "t600x-die0.dtsi"
41+
#include "t600x-dieX.dtsi"
42+
#include "t600x-nvme.dtsi"
4543
#include "t600x-gpio-pins.dtsi"
4644
#include "t600x-pmgr.dtsi"
4745

4846
#undef DIE
4947
#undef DIE_NO
48+
#undef SOC_NODE
5049

5150

5251
&aic {

arch/arm64/boot/dts/apple/t6002.dtsi

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -254,30 +254,28 @@
254254

255255
#define DIE
256256
#define DIE_NO 0
257+
#define SOC_NODE die0
257258

258-
&die0 {
259-
#include "t600x-die0.dtsi"
260-
#include "t600x-dieX.dtsi"
261-
};
262-
259+
#include "t600x-die0.dtsi"
260+
#include "t600x-dieX.dtsi"
263261
#include "t600x-pmgr.dtsi"
264262
#include "t600x-gpio-pins.dtsi"
265263

266264
#undef DIE
267265
#undef DIE_NO
266+
#undef SOC_NODE
268267

269268
#define DIE _die1
270269
#define DIE_NO 1
270+
#define SOC_NODE die1
271271

272-
&die1 {
273-
#include "t600x-dieX.dtsi"
274-
#include "t600x-nvme.dtsi"
275-
};
276-
272+
#include "t600x-dieX.dtsi"
273+
#include "t600x-nvme.dtsi"
277274
#include "t600x-pmgr.dtsi"
278275

279276
#undef DIE
280277
#undef DIE_NO
278+
#undef SOC_NODE
281279

282280
&aic {
283281
affinities {

arch/arm64/boot/dts/apple/t600x-die0.dtsi

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
* Copyright The Asahi Linux Contributors
77
*/
88

9-
9+
&SOC_NODE {
1010
nco: clock-controller@28e03c000 {
1111
compatible = "apple,t6000-nco", "apple,nco";
1212
reg = <0x2 0x8e03c000 0x0 0x14000>;
@@ -537,3 +537,4 @@
537537
status = "disabled";
538538
};
539539
};
540+
};

arch/arm64/boot/dts/apple/t600x-dieX.dtsi

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
* Copyright The Asahi Linux Contributors
77
*/
88

9+
&SOC_NODE {
910
DIE_NODE(cpufreq_e): cpufreq@210e20000 {
1011
compatible = "apple,t6000-cluster-cpufreq", "apple,t8103-cluster-cpufreq", "apple,cluster-cpufreq";
1112
reg = <0x2 0x10e20000 0 0x1000>;
@@ -331,3 +332,4 @@
331332
mode-switch;
332333
power-domains = <&DIE_NODE(ps_atc3_usb)>;
333334
};
335+
};

arch/arm64/boot/dts/apple/t600x-nvme.dtsi

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
* Copyright The Asahi Linux Contributors
66
*/
77

8+
&SOC_NODE {
89
DIE_NODE(ans_mbox): mbox@38f408000 {
910
compatible = "apple,t6000-asc-mailbox", "apple,asc-mailbox-v4";
1011
reg = <0x3 0x8f408000 0x0 0x4000>;
@@ -40,3 +41,4 @@
4041
power-domain-names = "ans", "apcie0", "apcie1";
4142
resets = <&DIE_NODE(ps_ans2)>;
4243
};
44+
};

0 commit comments

Comments
 (0)