Do not assume /dev/input is present#222
Open
WhatAmISupposedToPutHere wants to merge 1 commit intoAsahiLinux:mainfrom
Open
Do not assume /dev/input is present#222WhatAmISupposedToPutHere wants to merge 1 commit intoAsahiLinux:mainfrom
WhatAmISupposedToPutHere wants to merge 1 commit intoAsahiLinux:mainfrom
Conversation
WhatAmISupposedToPutHere
requested review from
alyssarosenzweig,
slp and
teohhanhui
as code owners
teohhanhui
reviewed
Apr 17, 2026
WhatAmISupposedToPutHere
force-pushed
the
main
branch
from
247e79d to
b2f49a5
Compare
teohhanhui
reviewed
Apr 17, 2026
| fs::read_dir("/dev/input/").context("Failed to read \"/dev/input/\" directory")? | ||
| { | ||
| let dir_ents = match fs::read_dir("/dev/input/") { | ||
| Ok(e) => Some(e), |
Collaborator
There was a problem hiding this comment.
It's quite confusing to name this e, even if it's referring to directory entries. 😆
(And I love shadowing.)
Suggested change
| Ok(e) => Some(e), | |
| Ok(dir_ents) => Some(dir_ents), |
It can be absent when running muvm inside of a container Supersedes: AsahiLinux#221 Suggested-by: Zewei Yang <yangzewei@loongson.cn> Signed-off-by: Sasha Finkelstein <k@chaosmail.tech>
WhatAmISupposedToPutHere
force-pushed
the
main
branch
from
b2f49a5 to
038daf5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's not make things complicated
Supersedes: #221