guest/net: Handle missing /etc/hostname gracefully #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannau
requested review from
alyssarosenzweig,
hoshinolina,
slp and
teohhanhui
as code owners
The error handled in AsahiLinux#74 was muvm-guest's network code. So fixing it here directly. Not sure if any of the binaries running in the guest actually care about /etc/hostname. Signed-off-by: Janne Grunau <janne-fdr@jannau.net>
jannau
force-pushed
the
missing_hostname
branch
from
73dc663 to
19184e6
Compare
jannau
changed the title
teohhanhui
approved these changes
Oct 8, 2024
alyssarosenzweig
approved these changes
Oct 8, 2024
Collaborator
|
Should we revert #74 or it's actually safer keeping it around? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error handled in #74 was muvm-guest's network code. So fixing it there directly. Not sure if any of the actual binaries running in the guest actually care about
/etc/hostname.