Add timeout to request library options. #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Something to consider - this does what you expect on a single call, but on a paged call I'm pretty sure it means it won't fetch any future pages once the |
theaeolianmachine
force-pushed
the
add_timeout_to_request_options
branch
from
66c7e65 to
180a96f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently you can't set a timeout on a request, leading to program hangs when the connection never gets back to you (I've ran into this personally a few times).
This adds the ability to set the timeout on any call, as recommended by requests:
http://docs.python-requests.org/en/master/user/quickstart/#timeouts
Would really love to be able to use this sometime soon.