[feat] Enable openYuanrong RDMA support#108
Open
KaisennHu wants to merge 1 commit into
Open
Conversation
Signed-off-by: Haichuan Hu <kaisennhu@gmail.com>
CLA Signature PassKaisennHu, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds configurable openYuanrong host RDMA support so TransferQueue can start Yuanrong datasystem workers with RDMA enabled and UCX environment overrides.
Changes:
- Added
enable_rdmaanducx_env_varsconfiguration options. - Wired RDMA flags and UCX environment handling into Yuanrong worker bootstrap.
- Updated openYuanrong documentation with RDMA setup and troubleshooting guidance.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
transfer_queue/config.yaml |
Adds default RDMA and UCX environment configuration fields. |
transfer_queue/storage/bootstrap/yuanrong_bootstrap.py |
Passes RDMA options through actor startup and applies UCX env precedence for dscli. |
docs/storage_backends/openyuanrong_datasystem.md |
Documents RDMA configuration, manual startup, and troubleshooting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+67
to
+68
| # UCX env vars passed to dscli subprocess. Overrides parent env. TQ defaults UCX_TLS=rc_x when enable_rdma=true. | ||
| # UCX_TLS: RDMA transport mode. "rc_x" (default), "rc" (compatible), "ud" (low-latency), "dc" (large-scale). |
| **RDMA Options:** | ||
| - `enable_rdma`: Whether to enable host RDMA (H2H) transport via UCX. Requires RDMA-capable NIC hardware and `rdma-core` driver on all nodes. When enabled, TQ automatically adds `--enable_rdma true` to the dscli startup command and defaults `UCX_TLS=rc_x` in the subprocess environment. RDMA H2H and RH2D (NPU cross-node) can be enabled simultaneously — they are **not** mutually exclusive. | ||
| - `ucx_env_vars`: Dictionary of UCX environment variables passed to the dscli subprocess. These override parent process environment. Common variables: | ||
| - `UCX_TLS`: RDMA transport mode. Defaults to `rc_x` when `enable_rdma=true` and not specified here. Alternatives: `rc` (compatible), `ud` (low-latency), `dc` (large-scale). See [UCX environment parameters](https://github.com/openucx/ucx/wiki/UCX-environment-parameters). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For 910B nodes with an additional RoCE NIC (besides NPU-side RoCE), openYuanrong datasystem supports host RDMA (H2H) transport via UCX. Since TQ routes CPU tensors through KV client and NPU tensors through tensor client by tensor location, H2H RDMA and RH2D can be enabled simultaneously — they are not mutually exclusive.
Previously, enabling RDMA required manually adding
--enable_rdma truetoworker_argsand settingUCX_TLS=rc_xin the environment. This PR introduces dedicated config options for one-click RDMA enablement.Changes
config.yaml: Addedenable_rdma(defaultfalse) anducx_env_vars(default{}). Whenenable_rdma=true, TQ auto-adds--enable_rdma trueto dscli cmd and defaultsUCX_TLS=rc_x.ucx_env_varslets users specify UCX env vars (UCX_TLS, UCX_LOG_FILE, UCX_LOG_LEVEL, UCX_NET_DEVICES, UCX_TCP_CM_ROUTE) with highest priority over parent env.yuanrong_bootstrap.py: Wiredenable_rdmaanducx_env_varsthrough config → actor →start_datasystem_worker. Env priority:ucx_env_vars> parent env > defaultUCX_TLS=rc_x.openyuanrong_datasystem.md: Added RDMA Options section, updated config examples, added manual RDMA startup instructions, and added RDMA FAQ (endpoint timeout, verification, container memlock).Related Issues
Closes #98