[perf] Refactor MooncakeStore backend with zero-copy upsert API#77
[perf] Refactor MooncakeStore backend with zero-copy upsert API#77ji-huazhong merged 10 commits intoAscend:mainfrom
Conversation
CLA Signature Pass0oshowero0, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
CLA Signature Pass0oshowero0, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
2 similar comments
CLA Signature Pass0oshowero0, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
CLA Signature Pass0oshowero0, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
Signed-off-by: 0oshowero0 <o0shower0o@outlook.com> try: use new mooncake API and enable zero-copy Signed-off-by: 0oshowero0 <o0shower0o@outlook.com> update Signed-off-by: 0oshowero0 <o0shower0o@outlook.com> update Signed-off-by: 0oshowero0 <o0shower0o@outlook.com> fix Signed-off-by: 0oshowero0 <o0shower0o@outlook.com>
Signed-off-by: 0oshowero0 <o0shower0o@outlook.com>
Signed-off-by: 0oshowero0 <o0shower0o@outlook.com>
Signed-off-by: 0oshowero0 <o0shower0o@outlook.com>
Signed-off-by: 0oshowero0 <o0shower0o@outlook.com>
1925ebf to
c2cd296
Compare
CLA Signature Pass0oshowero0, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Refactors the MooncakeStore backend integration to use newer “zero-copy” batch upsert/get APIs, adds buffer-prep utilities, enables hard-pin replication, and parallelizes preparation/transfer work.
Changes:
- Add tensor buffer utilities (grouped allocation, byte sizing, contiguous-region merging).
- Update MooncakeStore client to use
batch_upsert_from/batch_get_intofor tensors andupsert_batch/get_batchfor non-tensors, with multi-threaded batching. - Switch deletion to
batch_removeand hard-pin data during writes.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 18 comments.
| File | Description |
|---|---|
| transfer_queue/utils/tensor_utils.py | New utilities for zero-copy buffer preparation and memory-region merging. |
| transfer_queue/storage/clients/mooncake_client.py | Uses new MooncakeStore APIs, adds hard-pin replicate config, and multi-threaded put/get. |
| tests/e2e/test_kv_interface_e2e.py | Removes outdated comment about MooncakeStore update behavior. |
| pyproject.toml | Bumps mooncake-transfer-engine dependency version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CLA Signature Pass0oshowero0, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d178a88 to
c4c4198
Compare
CLA Signature Pass0oshowero0, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
Signed-off-by: 0oshowero0 <o0shower0o@outlook.com>
CLA Signature Pass0oshowero0, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
Signed-off-by: 0oshowero0 <o0shower0o@outlook.com>
CLA Signature Pass0oshowero0, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
CLA Signature Guide@ji-huazhong , thanks for your pull request. The following commit(s) are not associated with a signed Contributor License Agreement (CLA).
To sign CLA, click here. To check if your email is configured correctly, refer to the FAQs. Once you've signed the CLA or updating your email, please comment |
Signed-off-by: ji-huazhong <hzji210@gmail.com>
6f0fc06 to
8b09df0
Compare
CLA Signature Passji-huazhong, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
batch_upsert_from&batch_get_intofor tensorupsert_batch&get_batchfor non-tensorbatch_removeAPI for data clearning