Ensure all fields are sent #10

eric-elem · 2018-02-28T13:04:55Z

What does this PR do?

Ensures all fields from the requests form are sent to the backend

Tasks to be completed

Ensure fields from request form template aren't sent
Ensure fields that can have a single or many value(s) are always sent as arrays
Rename keys for array fields to be plural

How can this be tested

Add a print statement to print received payload in the dashboard POST endpoint in views.py. Run the server.
Visit the dashboard endpoint (e.g http://127.0.0.1:5000/dashboard), create some checks and click the save button.
Verify that the payload printed on the server console contains all the submitted fields

What is the relevant pivotal tracker story?

Story #155514650

feat(models): create models

add ci and coverage report

Ft authentication

feat(request): send request for monitoring

Creating checks

- Move login script to a separate file [Delivers #155514460]

Center login button

- ensure the save and run buttons are clear and self descriptive [Delivers #155514841]

Ashaba · 2018-02-28T17:27:04Z

application/static/js/dashboard.js

+
+    if(data.length > 0) {
+        $.ajax({
+            url: 'http://127.0.0.1:5000/dashboard',


Is there a way we can ensure the url is not hardcoded? For example pushing this code to another server would lead to failure.

Think of getting the host using JQuery

Thanks @Ashaba. I have changed this to url: '/dashboard'. This way, Ajax will automatically append /dashboard to whatever the current root url is.

coveralls · 2018-03-01T08:34:17Z

Pull Request Test Coverage Report for Build #54

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 31.454%

Totals
Change from base Build #51:	0.0%
Covered Lines:	24405
Relevant Lines:	77590

💛 - Coveralls

muhallan · 2018-03-02T08:17:40Z

application/static/js/dashboard.js

+            data: JSON.stringify(data),
+            contentType: "application/json; charset=utf-8",
+            success: function (response) {
+                console.log(response);


Should logs be allowed in production code?

No, they shouldn't. I added this line for debug purposes and forgot to remove it. I have removed it now. I suggest we add a story to automate checking of such using git hooks. CC @Ashaba

#155514841 Make the dashboard buttons clear

chore(readme): add readme content

muhallan · 2018-03-05T13:17:08Z

Please rebase with develop.

[Delivers #155514650]

muhallan · 2018-03-05T13:23:44Z

I have noticed that one can send multiple headers with the same key and they are allowed. Is that the accepted behaviour?

Ashaba

Add tests.

muhallan · 2018-03-07T13:10:42Z

@Ashaba why have you closed this?

Ashaba · 2018-03-07T13:27:20Z

Please create a new PR

Ashaba and others added 18 commits January 30, 2018 17:56

Initial commit

c6a159a

feat(setup): initial project set up

beb6213

chore(setup): remove .idea

458aba9

feat(models): create models

d3fdebb

Merge pull request #2 from Ashaba/ft-create-models-migrations-154767737

c9c3c5b

feat(models): create models

add ci and coverage report

995565a

Merge pull request #3 from Ashaba/ft-add-continous-integration

038ee1d

add ci and coverage report

Update README.md

e56fba6

feat(deployment): deploy code to heroku

e2e71cd

feat(auth): add google login and templates

ff8ec70

Merge pull request #4 from Ashaba/ft-authentication

d4e072e

Ft authentication

feat(request): send request for monitoring

1d73e61

Merge pull request #5 from Ashaba/ft-create-schedule

3a2a658

feat(request): send request for monitoring

ft(checks): Add checks creation form

c5e9895

Merge pull request #6 from Ashaba/ft-checks-form

cfd7952

Creating checks

ch(login): Center login button

7058f75

- Move login script to a separate file [Delivers #155514460]

Merge pull request #7 from Ashaba/ch-center-login-button

f40c9d3

Center login button

chore(buttons): make the dashboard buttons clear

90e71aa

- ensure the save and run buttons are clear and self descriptive [Delivers #155514841]

eric-elem requested review from Ashaba and muhallan February 28, 2018 13:05

Ashaba reviewed Feb 28, 2018

View reviewed changes

eric-elem force-pushed the ch-requests-payload branch from 7285d0c to c272aee Compare March 1, 2018 08:31

muhallan reviewed Mar 2, 2018

View reviewed changes

Ashaba added 2 commits March 2, 2018 14:44

Merge pull request #9 from Ashaba/ch-clear-buttons-155514841

ed4a852

#155514841 Make the dashboard buttons clear

chore(readme): add readme content

a2f979c

eric-elem force-pushed the ch-requests-payload branch from c272aee to f1c7052 Compare March 5, 2018 08:52

Ashaba added 2 commits March 5, 2018 12:34

Update README.md

6e41eb7

Merge pull request #8 from Ashaba/ch-add-readme-155514841

8beed52

chore(readme): add readme content

ch(requests): Ensure all fields are sent

31b7375

[Delivers #155514650]

eric-elem force-pushed the ch-requests-payload branch from f1c7052 to 31b7375 Compare March 5, 2018 13:18

Ashaba requested changes Mar 5, 2018

View reviewed changes

Ashaba closed this Mar 7, 2018

Ashaba force-pushed the develop branch from 8beed52 to 319dc86 Compare March 7, 2018 12:54

eric-elem deleted the ch-requests-payload branch March 29, 2018 06:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ensure all fields are sent #10

Ensure all fields are sent #10

Uh oh!

eric-elem commented Feb 28, 2018

Uh oh!

Ashaba Feb 28, 2018

Uh oh!

eric-elem Mar 1, 2018

Uh oh!

coveralls commented Mar 1, 2018 •

edited

Loading

Uh oh!

muhallan Mar 2, 2018

Uh oh!

eric-elem Mar 5, 2018 •

edited

Loading

Uh oh!

muhallan commented Mar 5, 2018

Uh oh!

muhallan commented Mar 5, 2018

Uh oh!

Ashaba left a comment

Uh oh!

muhallan commented Mar 7, 2018

Uh oh!

Ashaba commented Mar 7, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Ensure all fields are sent #10

Ensure all fields are sent #10

Uh oh!

Conversation

eric-elem commented Feb 28, 2018

What does this PR do?

Tasks to be completed

How can this be tested

What is the relevant pivotal tracker story?

Uh oh!

Ashaba Feb 28, 2018

Choose a reason for hiding this comment

Uh oh!

eric-elem Mar 1, 2018

Choose a reason for hiding this comment

Uh oh!

coveralls commented Mar 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build #54

💛 - Coveralls

Uh oh!

muhallan Mar 2, 2018

Choose a reason for hiding this comment

Uh oh!

eric-elem Mar 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

muhallan commented Mar 5, 2018

Uh oh!

muhallan commented Mar 5, 2018

Uh oh!

Ashaba left a comment

Choose a reason for hiding this comment

Uh oh!

muhallan commented Mar 7, 2018

Uh oh!

Ashaba commented Mar 7, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

coveralls commented Mar 1, 2018 •

edited

Loading

eric-elem Mar 5, 2018 •

edited

Loading