Skip to content

#155450742 Add scheduler collection#25

Merged
Ashaba merged 9 commits intodevelopfrom
add-scheduler-collection-155450742
May 2, 2018
Merged

#155450742 Add scheduler collection#25
Ashaba merged 9 commits intodevelopfrom
add-scheduler-collection-155450742

Conversation

@Ashaba
Copy link
Owner

@Ashaba Ashaba commented May 2, 2018

What does this PR do?

It enables background scheduling

Description of Task to be completed?

The front end runs concurrently with background process to check for scheduled checks and runs them.
This updates the database on completion

How should this be manually tested?

  • Install all the requirements in the requirements.txt
  • Start redis redis-server
  • Start the celery beat celery beat -A celery_worker.celery --loglevel=info
    Ensure to update the config at this stage CELERY_IMPORTS = ("application.monitoring_tasks",)
  • Start the celery worker celery worker -A celery_worker.celery --loglevel=info
  • Add a collection and its duration of 1 minute
  • Add requests to the collection and wait for the 1 minute.
    Apparently the UI is not updated automatically, on refreshing the page, results should show on the dashboard.

Any background context you want to provide?

These checks are currently testing only status code and the response time

What are the relevant pivotal tracker stories?

155450742

Screenshots (if appropriate)

screen shot 2018-05-02 at 17 21 49

@Ashaba Ashaba requested review from eric-elem and muhallan May 2, 2018 14:22
@Ashaba Ashaba force-pushed the add-scheduler-collection-155450742 branch from a37e800 to 401967f Compare May 2, 2018 14:47
@coveralls
Copy link

coveralls commented May 2, 2018

Pull Request Test Coverage Report for Build 228

  • 105 of 154 (68.18%) changed or added relevant lines in 21 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.5%) to 38.136%

Changes Missing Coverage Covered Lines Changed/Added Lines %
application/base_model.py 3 4 75.0%
application/monitoring_tasks.py 24 32 75.0%
application/views.py 10 20 50.0%
application/helpers.py 11 41 26.83%
Files with Coverage Reduction New Missed Lines %
application/base_model.py 1 72.73%
venv/lib/python3.6/site-packages/jinja2/environment.py 9 44.08%
Totals Coverage Status
Change from base Build 222: 0.5%
Covered Lines: 32467
Relevant Lines: 85134

💛 - Coveralls

@Ashaba Ashaba force-pushed the add-scheduler-collection-155450742 branch 4 times, most recently from 0c5ec65 to eef8240 Compare May 2, 2018 16:22
@Ashaba Ashaba force-pushed the add-scheduler-collection-155450742 branch from eef8240 to 6f74c9d Compare May 2, 2018 16:55
@Ashaba Ashaba merged commit dce48fe into develop May 2, 2018
@Ashaba Ashaba deleted the add-scheduler-collection-155450742 branch May 2, 2018 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants