Dev #2
Open
Dev #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i-masloed
reviewed
Jun 30, 2024
There was a problem hiding this comment.
Рекомендация: файлы директорий .idea и build стоит вынести в .gitignore
src/main/java/Main.java
Outdated
|
|
||
| for (int i = 1; i <= 3; i++) { | ||
| System.out.println("Введите название машины №" + i + ": "); | ||
| Car.car = scanner.next(); |
There was a problem hiding this comment.
Здесь нужно создавать ноdый экземпляр класса : Car car = new Car(name, speed)
src/main/java/Main.java
Outdated
| while (true) { | ||
| System.out.println("Введите скорость машины №" + i + ": "); | ||
| Car.speed = scanner.nextInt(); | ||
| if ((Car.speed >= 0) & (Car.speed <= 250)) { |
There was a problem hiding this comment.
Критично: & - это побитовое И, здесь нужно логическое &&
src/main/java/Race.java
Outdated
|
|
||
|
|
||
| public static void nowLead(Car car) { | ||
| int distance = Car.speed * 24; |
There was a problem hiding this comment.
здесь по сути идет проверка только по последней введенной скорости. Нужно взять 3 экземпляра авто(списком), пройтись по ним циклом и определить победителя
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.