Skip to content

Authentication#22

Merged
hadeer-r merged 6 commits into
Askfm-clone:Developfrom
hadeer-r:Authentication
Aug 25, 2025
Merged

Authentication#22
hadeer-r merged 6 commits into
Askfm-clone:Developfrom
hadeer-r:Authentication

Conversation

@hadeer-r
Copy link
Copy Markdown
Contributor

@hadeer-r hadeer-r commented Aug 25, 2025

#16

This Pr Contain

  1. Full Authentication for user module
  2. Handeling Following operations

Prograss

Done:

  • Provide response server pattern
  • Implement Authentication using jwt and refresh token
  • Service Layer: Create 2 Services one for Authentication and the other for user operations
  • API Layer:
    • Auth Controller: and most of its endpoint not authorized as it's used for authentications process and handleing tokens lifes
    • User Congroller: authorized controller for user usuall operations
  • Migratins:
    • Adding new table: refresh table, and it's idependent to user tables

TODO:

  • getuserbyid
  • EditUser
  • reset password
  • confirm email
  • follow user
  • unfollow user
  • delete user
  • last seen middleware
  • unit testing for services and APIs

needed Refatoring:

  • Map DTOs in app layer not service layer
  • enhancement the implementatin for logout api
  • make new token in referesh process to take the same expire date as previous to prevent inite available token

Task Grading Bot added 6 commits August 17, 2025 12:37
- Provide response server pattern
- Implement Authentication using jwt and refresh token
- Service Layer
	- Create 2 Services one for Authentication and the other for user operations
- APIs
	- Auth Controller: and most of its endpoint not authorized as it's used for authentications process and handleing tokens lifes
	- User Congroller: authorized controller for user usuall operations
- Completed APIs
	- register
	- login
	- Refresh Token
	- logout
	- get current user

APIs TODO:
- getuserbyid
- EditUser
- reset password
- confirm email

needed Refatoring:
1. Map DTOs in app layer not service layer
2. make new token in referesh process to take the same expire date as previous to prevent inite available token
3. enhancement the implementatin for logout api
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Aug 25, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

return Ok(result);
}

[HttpGet]
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change HttpGet to HttpPost for more security level

@hadeer-r hadeer-r merged commit 94126ef into Askfm-clone:Develop Aug 25, 2025
2 checks passed
@hadeer-r
Copy link
Copy Markdown
Contributor Author

Move Token_Exp & Refresh_Exp to appsettings.json

@hadeer-r hadeer-r mentioned this pull request Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant