Merged
Conversation
- Add automatic Stockfish binary detection across Linux and macOS - Change verl submodule URL from SSH to HTTPS for easier access - Fix chess puzzle test with proper pytest_asyncio fixture - Correct test logic for multi-move puzzle state tracking
…ming - Change model_name_or_path from "mock-model" to "Qwen/Qwen2.5-3B-Instruct" so get_template resolves correctly without mocking - Remove unnecessary create_tokenizer/create_processor patches - Rename chess reward parameter from "prediction" to "final_response" to match what chain_base passes to reward functions - Export chess rewards from rewards __init__.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.