Make setMemory require segments array (even if empty) #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Yeah, might need an improvement on the binaryen side, but the fix is good, thanks! |
dcodeIO
added a commit
to dcodeIO/binaryen
that referenced
this pull request
Nov 29, 2017
Currenty throws if omitted, see AssemblyScript/binaryen.js#2
kripken
pushed a commit
to WebAssembly/binaryen
that referenced
this pull request
Nov 29, 2017
Currenty throws if omitted, see AssemblyScript/binaryen.js#2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current type signature says that segments is optional, but it unfortunately isn't currently. (produces segments.map errors).
This is a bit of an awkward type signature since indeed the exportName has to be optional because it being provided means it should be exported.
It's possible the ideal solution is to make segments optional, but until that time I figured this was easy enough to correct.
The README has the correct signature already. Though because JavaScript is so awesome the signature
string|null|undefinedmight be more flexible. Your call, I can change the README.number, maximum:number, exportName:string | null, segments:MemorySegment[]):voidSets the memory. There's just one memory for now, using name
"0". ProvidingexportNamealso creates a memory export.