Add new check option to ReadWasmOptions, with test.#53
Merged
Conversation
pdubroy
changed the title
check option to ``ReadWasmOptions, with test.check option to ReadWasmOptions, with test.
Contributor
Author
|
Also, maybe worth bumping the version number for this? |
Member
|
We seem to just follow WABT's versioning, so a version bump won't be needed. |
Contributor
Author
|
@CountBleck Ah, ok, didn't realize that. Are you able to merge this? It's a pretty trivial change but it would be nice to keep the wabt.js types up to date with upstream. |
CountBleck
approved these changes
Apr 11, 2025
Co-authored-by: CountBleck <Mr.YouKnowWhoIAm@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest nightly includes a new option in wasm2wat — you can pass
check: falseto allow invalid modules to be loaded, similar to passing--no-checkin the wasm2wat CLI. Original commit here: WebAssembly/wabt@5fdc745This PR updates
ReadWasmOptionsto include the newcheckoption, and adds a small test.