You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Great work!
It feels more like a recommendation than a specification. We should add the Trusted Contract specification with proper errors & inputs like in other PSPs
Great work! It feels more like a recommendation than a specification. We should add the Trusted Contract specification with proper errors & inputs like in other PSPs
Thank you for comment, I agree that partially. I think we should better reconsider the scope of this proposal if needed.
The original ERC2771's scope is how to transmit address as extra bytes and recover it as you can see in the diagram at Example Workflow section (https://eips.ethereum.org/EIPS/eip-2771). So, the way how to verify signatures and other Trusted Forwarder contract's specification including function signatures are out of scope.
I'll rework on Proposal draft, expanding the scope to include contract interfaces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Meta Transaction standard proposal. ERC2771 correspondance.