Conversation
Useful when updating supported Python versions for different packages in the ecosystem one at a time...
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 7 7
=========================================
Hits 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Unfortunately I kind of urgently need this in Scopesim-Targets, because I need to drop Python 3.10 there. So I'll just merge this and deal with potential issues afterwards. Sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Useful when updating supported Python versions for different packages in the ecosystem one at a time...
Annoyingly, the defaults now have to be stored in two places, because of different contexts when running on push/PR here vs. when called from elsewhere. Alternative solution would be to use these strictly as called workflows, and have another workflow that acts as the caller on push/PR, much like these are called from elsewhere anyway. I think that's also how we solved a similar issue in the IRDB. But we can always come back and do that, it wouldn't change the outside call signature...