Skip to content

Fix stsci urls#92

Merged
hugobuddel merged 2 commits intomainfrom
fix-stsci-urls
Apr 25, 2026
Merged

Fix stsci urls#92
hugobuddel merged 2 commits intomainfrom
fix-stsci-urls

Conversation

@hugobuddel
Copy link
Copy Markdown
Contributor

@hugobuddel hugobuddel commented Apr 25, 2026

Aaaaaaa

anyway. sorry about that

forgot to add .*

This also adds workflow_dispatch

Edit: followup to #90

@hugobuddel hugobuddel requested a review from teutoburg April 25, 2026 12:18
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (89babec) to head (992d40c).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #92   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines            7         7           
=========================================
  Hits             7         7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@teutoburg teutoburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I didn't actually look at the pattern ^^

@hugobuddel hugobuddel merged commit 2d1c22d into main Apr 25, 2026
22 checks passed
@hugobuddel hugobuddel deleted the fix-stsci-urls branch April 25, 2026 12:36
@hugobuddel
Copy link
Copy Markdown
Contributor Author

It worked: https://github.com/AstarVienna/irdb/actions/runs/24931054010

@teutoburg
Copy link
Copy Markdown
Contributor

@hugobuddel
Copy link
Copy Markdown
Contributor Author

That one says

README.md:12:1: 🚫 https://news.ycombinator.com/item?id=36354464 Status:429 Cannot reach link

Apparently 429 means "Too Many Requests". Which I suppose we cannot do too much about, since it is the github runner who is making the requests.

Maybe we should run the markdown test less frequently, like only once a month or so. Because it is good to run, but there is no need to do it very often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants