Skip to content

Fixup adding mock path to UserCommands#640

Merged
teutoburg merged 1 commit intomainfrom
fh/fixupmockpath
Apr 8, 2025
Merged

Fixup adding mock path to UserCommands#640
teutoburg merged 1 commit intomainfrom
fh/fixupmockpath

Conversation

@teutoburg
Copy link
Copy Markdown
Contributor

As was pointed out by @hugobuddel in #627 (comment), using relative paths here is generally wrong.

Also, using patch_fake_symlinks on the mock path can create undesired results.

Also, over in the tests, the fixture needs to be applied on a function level.

As was pointed out by @hugobuddel in #627 (comment), using relative paths here is generally wrong.

Also, using patch_fake_symlinks on the mock path can create undesired results.

Also, over in the tests, the fixture needs to be applied on a function level.
@teutoburg teutoburg moved this from 🆕 New to 👀 Awaiting Review in ScopeSim-development Apr 8, 2025
@teutoburg teutoburg self-assigned this Apr 8, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.74%. Comparing base (d793e2c) to head (7ce187a).
Report is 281 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #640   +/-   ##
=======================================
  Coverage   76.74%   76.74%           
=======================================
  Files          70       70           
  Lines        8576     8576           
=======================================
  Hits         6582     6582           
  Misses       1994     1994           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@teutoburg teutoburg marked this pull request as ready for review April 8, 2025 23:25
@teutoburg teutoburg merged commit 2df27ec into main Apr 8, 2025
22 checks passed
@teutoburg teutoburg deleted the fh/fixupmockpath branch April 8, 2025 23:26
@github-project-automation github-project-automation Bot moved this from 👀 Awaiting Review to ✅ Done in ScopeSim-development Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant