Conversation
As was pointed out by @hugobuddel in #627 (comment), using relative paths here is generally wrong. Also, using patch_fake_symlinks on the mock path can create undesired results. Also, over in the tests, the fixture needs to be applied on a function level.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #640 +/- ##
=======================================
Coverage 76.74% 76.74%
=======================================
Files 70 70
Lines 8576 8576
=======================================
Hits 6582 6582
Misses 1994 1994 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As was pointed out by @hugobuddel in #627 (comment), using relative paths here is generally wrong.
Also, using patch_fake_symlinks on the mock path can create undesired results.
Also, over in the tests, the fixture needs to be applied on a function level.