Skip to content

Transmission curves to extrapolate with value 0#859

Merged
oczoske merged 1 commit intomainfrom
oc/fix_svo_filter
Jan 8, 2026
Merged

Transmission curves to extrapolate with value 0#859
oczoske merged 1 commit intomainfrom
oc/fix_svo_filter

Conversation

@oczoske
Copy link
Collaborator

@oczoske oczoske commented Jan 8, 2026

Some SVO filters (e.g. NACO filters) do not drop to zero transmission at the edges of their wavelength range. Scopesim's download_svo_filter used to create synphot SpectralElements with (implicit) fill_value=nan, which means that the filter curves are extrapolated with constant values equal to the edge values, resulting in potentially huge leaks. This PR sets fill_value=0. explicitely, removing those leaks.

This fixes the main discrepancy in AstarVienna/HowManyBloodyPhotons#40.

@oczoske oczoske requested a review from teutoburg January 8, 2026 10:37
@oczoske oczoske self-assigned this Jan 8, 2026
@oczoske oczoske added bugfix PR resolving one or more bugs (use "Bug" type for issues, not this label) effects Related to a ScopeSim effect labels Jan 8, 2026
@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.87%. Comparing base (c348806) to head (ead783a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #859   +/-   ##
=======================================
  Coverage   74.87%   74.87%           
=======================================
  Files          69       69           
  Lines        8863     8863           
=======================================
  Hits         6636     6636           
  Misses       2227     2227           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oczoske oczoske merged commit d372524 into main Jan 8, 2026
98 of 101 checks passed
@oczoske oczoske deleted the oc/fix_svo_filter branch January 8, 2026 14:14
oczoske added a commit to AstarVienna/ScopeSim_Templates that referenced this pull request Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PR resolving one or more bugs (use "Bug" type for issues, not this label) effects Related to a ScopeSim effect

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants