Skip to content

Read fp_mask_{}.dat explicitely as float#869

Merged
oczoske merged 1 commit intomainfrom
oc/fix_868
Jan 23, 2026
Merged

Read fp_mask_{}.dat explicitely as float#869
oczoske merged 1 commit intomainfrom
oc/fix_868

Conversation

@oczoske
Copy link
Copy Markdown
Collaborator

@oczoske oczoske commented Jan 23, 2026

Positions for the pinhole in the METIS WCU focal-plane mask were given as (0, 0) in e.g. fp_mask_pinhole_lm.dat (in the irdb). The hole positions were then initialised as int. In combination with a shift argument given as float (e.g. 0.5) this caused an error since the shift is applied in-place via +=. This PR converts the entries in the mask table explicitely to float since that is the assumed data type for hole positions anyway.

Closes #868

@oczoske oczoske requested a review from teutoburg January 23, 2026 14:49
@oczoske oczoske self-assigned this Jan 23, 2026
@oczoske oczoske added bugfix PR resolving one or more bugs (use "Bug" type for issues, not this label) METIS AIT Issues relating to METIS AIT simulations labels Jan 23, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.88%. Comparing base (c4bd454) to head (780ec3d).
⚠️ Report is 122 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #869   +/-   ##
=======================================
  Coverage   74.88%   74.88%           
=======================================
  Files          69       69           
  Lines        8870     8870           
=======================================
  Hits         6642     6642           
  Misses       2228     2228           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oczoske oczoske merged commit 0a2c01c into main Jan 23, 2026
68 of 69 checks passed
@oczoske oczoske deleted the oc/fix_868 branch January 23, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PR resolving one or more bugs (use "Bug" type for issues, not this label) METIS AIT Issues relating to METIS AIT simulations

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Possible format error in WCU configuration file 'fp_mask_pinhole_lm.dat'

2 participants