Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #878 +/- ##
==========================================
- Coverage 74.83% 74.82% -0.01%
==========================================
Files 69 69
Lines 8868 8869 +1
==========================================
Hits 6636 6636
- Misses 2232 2233 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
teutoburg
approved these changes
Feb 18, 2026
Contributor
teutoburg
left a comment
There was a problem hiding this comment.
Always surprising to find such rather obvious things...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The METIS/IFU notebook used an input cube in which
CDELT1was negative. This resulted in a negative source trace imprinted on positive background. The reason is thatOpticalTrain.prepare_source()divides the cube data by the pixel area (solid angle), which was computed fromCDELT1andCDELT2and came out negative. This PR uses the absolute value of the pixel area so that the cube data remain positive.