Fix PupilTransmission emission after update#900
Merged
Conversation
oczoske
added
bugfix
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #900 +/- ##
=======================================
Coverage 74.79% 74.79%
=======================================
Files 69 69
Lines 8944 8944
=======================================
Hits 6690 6690
Misses 2254 2254 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
teutoburg
approved these changes
Apr 10, 2026
github-project-automation
Bot
moved this from 👀 Awaiting Review
to ✅ Done
in ScopeSim-development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PupilTransmission().update_transmissionused to reinstantiateSpectralSurfacewithemissionwithout units, which causedapply_toto fail. This was not unit tested, hence went unnoticed. The PR reinstantiatesSpectralSurfacewithemissivity, which is used to constructemission. A new test checks thatemissionnow has correct units; this fails with the old and passes with the new code.