Skip to content

Fibre transmission for WCU lasers#904

Merged
oczoske merged 1 commit intomainfrom
oc/wcu_fibre_trans
Apr 15, 2026
Merged

Fibre transmission for WCU lasers#904
oczoske merged 1 commit intomainfrom
oc/wcu_fibre_trans

Conversation

@oczoske
Copy link
Copy Markdown
Collaborator

@oczoske oczoske commented Apr 14, 2026

Add fibre transmission for the METIS WCU lasers. The value is defined in AstarVienna/irdb#334

If needed, it can be changed with

wcu.fibre_trans = 0.5
wcu.set_lamp("laser")    # needed to recompute the emergent intensity
metis.observe()

The figure shows the effect for five different values on the ImagePlane, where the thermal background has been subtracted.
fibre_trans_test

@oczoske oczoske requested a review from teutoburg April 14, 2026 16:34
@oczoske oczoske self-assigned this Apr 14, 2026
@oczoske oczoske added instrument-specific effects Related to a ScopeSim effect METIS AIT Issues relating to METIS AIT simulations labels Apr 14, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.11%. Comparing base (63c3876) to head (281e04e).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #904      +/-   ##
==========================================
+ Coverage   74.81%   75.11%   +0.30%     
==========================================
  Files          69       69              
  Lines        8948     8953       +5     
==========================================
+ Hits         6694     6725      +31     
+ Misses       2254     2228      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@teutoburg teutoburg moved this to 👀 Awaiting Review in ScopeSim-development Apr 14, 2026
Copy link
Copy Markdown
Contributor

@teutoburg teutoburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread scopesim/effects/metis_wcu/metis_wcu.py
@oczoske oczoske merged commit db7a81b into main Apr 15, 2026
26 checks passed
@oczoske oczoske deleted the oc/wcu_fibre_trans branch April 15, 2026 07:36
@github-project-automation github-project-automation Bot moved this from 👀 Awaiting Review to ✅ Done in ScopeSim-development Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effects Related to a ScopeSim effect instrument-specific METIS AIT Issues relating to METIS AIT simulations

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants