Skip to content

Squeeze extra dimensions out of PSF kernel#908

Merged
teutoburg merged 4 commits intomainfrom
fh/squeeze-psf
Apr 29, 2026
Merged

Squeeze extra dimensions out of PSF kernel#908
teutoburg merged 4 commits intomainfrom
fh/squeeze-psf

Conversation

@teutoburg
Copy link
Copy Markdown
Contributor

@teutoburg teutoburg commented Apr 23, 2026

Required to run current TipTop PSFs. Does not alter anything with already no extra dimensions, so should be safe.

@teutoburg teutoburg self-assigned this Apr 23, 2026
@teutoburg teutoburg added the enhancement PR adding or improving a feature (use "Feature" type for issues (requests), not this label) label Apr 23, 2026
@teutoburg teutoburg moved this to 👀 Awaiting Review in ScopeSim-development Apr 23, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.18%. Comparing base (a669398) to head (6edc2fd).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #908   +/-   ##
=======================================
  Coverage   75.18%   75.18%           
=======================================
  Files          70       70           
  Lines        9016     9016           
=======================================
  Hits         6779     6779           
  Misses       2237     2237           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@teutoburg teutoburg moved this from 👀 Awaiting Review to 🏗 In progress in ScopeSim-development Apr 23, 2026
@teutoburg teutoburg marked this pull request as draft April 23, 2026 17:30
@teutoburg teutoburg marked this pull request as ready for review April 27, 2026 21:43
@teutoburg teutoburg moved this from 🏗 In progress to 👀 Awaiting Review in ScopeSim-development Apr 27, 2026
@teutoburg teutoburg requested a review from oczoske April 27, 2026 21:43
Copy link
Copy Markdown
Collaborator

@oczoske oczoske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The xfails are worrying but they're documented in #911.
See the comment on stopping the squeeze at ndim=2.

Comment thread scopesim/effects/psfs/discrete.py Outdated
@teutoburg teutoburg requested a review from oczoske April 28, 2026 10:45
Comment thread scopesim/effects/psfs/discrete.py
@teutoburg teutoburg merged commit d0f4fe5 into main Apr 29, 2026
26 checks passed
@teutoburg teutoburg deleted the fh/squeeze-psf branch April 29, 2026 11:43
@github-project-automation github-project-automation Bot moved this from 👀 Awaiting Review to ✅ Done in ScopeSim-development Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement PR adding or improving a feature (use "Feature" type for issues (requests), not this label)

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants