Skip to content

fix(ci): suppress nightly generated release notes#124

Merged
zouyonghe merged 1 commit intoAstrBotDevs:mainfrom
zouyonghe:codex/fix-nightly-release-notes
Apr 28, 2026
Merged

fix(ci): suppress nightly generated release notes#124
zouyonghe merged 1 commit intoAstrBotDevs:mainfrom
zouyonghe:codex/fix-nightly-release-notes

Conversation

@zouyonghe
Copy link
Copy Markdown
Member

@zouyonghe zouyonghe commented Apr 28, 2026

Summary

This PR stops nightly GitHub releases from using GitHub's generated release notes.

The nightly release uses a stable nightly tag that is updated repeatedly. With generate_release_notes: true, GitHub compares the moving nightly tag against repository history and can show a very large "What's Changed" section containing unrelated or accumulated PRs. That makes the nightly release page noisy and misleading for users who only need the current package metadata and assets.

The workflow now enables generated release notes only for non-nightly builds, so stable/tag-poll releases keep their generated changelog while nightly releases keep the explicit workflow body. A workflow-level regression test was added so the nightly exception does not get removed accidentally.

Test Plan

  • pnpm run test:prepare-resources
  • git diff --check

Summary by Sourcery

Adjust nightly desktop release workflow to avoid using GitHub-generated release notes while keeping them for non-nightly builds.

CI:

  • Conditionally disable GitHub-generated release notes in the desktop Tauri release job when the build mode is nightly.
  • Add a workflow test ensuring the nightly release job keeps generated release notes disabled.

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@zouyonghe zouyonghe merged commit 732b1bd into AstrBotDevs:main Apr 28, 2026
4 checks passed
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new test case to the CI workflow testing suite to verify that generated release notes are disabled for nightly builds. It introduces a constant for the release job and implements an assertion to check the 'generate_release_notes' configuration in the GitHub Actions workflow. I have no feedback to provide as there were no review comments to evaluate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant