fix(ci): suppress nightly generated release notes#124
Merged
zouyonghe merged 1 commit intoAstrBotDevs:mainfrom Apr 28, 2026
Merged
fix(ci): suppress nightly generated release notes#124zouyonghe merged 1 commit intoAstrBotDevs:mainfrom
zouyonghe merged 1 commit intoAstrBotDevs:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a new test case to the CI workflow testing suite to verify that generated release notes are disabled for nightly builds. It introduces a constant for the release job and implements an assertion to check the 'generate_release_notes' configuration in the GitHub Actions workflow. I have no feedback to provide as there were no review comments to evaluate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR stops nightly GitHub releases from using GitHub's generated release notes.
The nightly release uses a stable
nightlytag that is updated repeatedly. Withgenerate_release_notes: true, GitHub compares the moving nightly tag against repository history and can show a very large "What's Changed" section containing unrelated or accumulated PRs. That makes the nightly release page noisy and misleading for users who only need the current package metadata and assets.The workflow now enables generated release notes only for non-nightly builds, so stable/tag-poll releases keep their generated changelog while nightly releases keep the explicit workflow body. A workflow-level regression test was added so the nightly exception does not get removed accidentally.
Test Plan
pnpm run test:prepare-resourcesgit diff --checkSummary by Sourcery
Adjust nightly desktop release workflow to avoid using GitHub-generated release notes while keeping them for non-nightly builds.
CI: