Skip to content

fix: handle image value correctly for mcp BlobResourceContents#2753

Merged
Soulter merged 1 commit intomasterfrom
fix/mcp-tool-embedded-resources-image-handle
Sep 16, 2025
Merged

fix: handle image value correctly for mcp BlobResourceContents#2753
Soulter merged 1 commit intomasterfrom
fix/mcp-tool-embedded-resources-image-handle

Conversation

@Soulter
Copy link
Copy Markdown
Member

@Soulter Soulter commented Sep 14, 2025


Motivation / 动机

修复错误

Modifications / 改动点

修复 mcp EmbeddedResource 下 BlobResourceContents 的值引用错误。

应该是 resource.blob 而不是 res.content[0].data

Verification Steps / 验证步骤

Screenshots or Test Results / 运行截图或测试结果

Compatibility & Breaking Changes / 兼容性与破坏性变更

  • 这是一个破坏性变更 (Breaking Change)。/ This is a breaking change.
  • 这不是一个破坏性变更。/ This is NOT a breaking change.

Checklist / 检查清单

  • 😊 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。/ If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
  • 👀 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”。/ My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
  • 🤓 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到了 requirements.txtpyproject.toml 文件相应位置。/ I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in requirements.txt and pyproject.toml.
  • 😮 我的更改没有引入恶意代码。/ My changes do not introduce malicious code.

Sourcery 总结

Bug 修复:

  • 将对 res.content[0].data 的错误引用替换为 resource.blob,用于工具循环代理运行器中的图像数据处理。
Original summary in English

Summary by Sourcery

Bug Fixes:

  • Replace incorrect reference to res.content[0].data with resource.blob for image data handling in tool loop agent runner.

@auto-assign auto-assign Bot requested review from Larch-C and Raven95676 September 14, 2025 10:04
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嘿,你好!我已经审阅了你的更改,它们看起来很棒!


Sourcery 对开源项目免费 - 如果你喜欢我们的评论,请考虑分享它们 ✨
帮我变得更有用!请在每条评论上点击 👍 或 👎,我将利用这些反馈来改进你的评论。
Original comment in English

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Soulter Soulter merged commit 91ee0a8 into master Sep 16, 2025
4 checks passed
kawayiYokami pushed a commit to kawayiYokami/AstrBot that referenced this pull request Sep 17, 2025
@Soulter Soulter deleted the fix/mcp-tool-embedded-resources-image-handle branch October 18, 2025 01:54
united-pooh pushed a commit to united-pooh/AstrBot that referenced this pull request Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant