Skip to content

Fix(ui): always show actions btn instead of on hover in OutlinedActionListItem#8081

Merged
RC-CHN merged 1 commit into
AstrBotDevs:masterfrom
M1LKT:master
May 9, 2026
Merged

Fix(ui): always show actions btn instead of on hover in OutlinedActionListItem#8081
RC-CHN merged 1 commit into
AstrBotDevs:masterfrom
M1LKT:master

Conversation

@M1LKT
Copy link
Copy Markdown
Contributor

@M1LKT M1LKT commented May 8, 2026

目前MCP/Skill的管理界面,各种操作的按钮需要鼠标hover在对应的那一行div上才显示,这很反直觉和不方便使用
c5d9a4379aa94fcdcb762d3262bf72d3

dc635a86df14cf7227ab8c088fdb2dbc 当前效果如上图所示

Modifications / 改动点

修改了按钮的渲染条件,常态显示

  • This is NOT a breaking change. / 这不是一个破坏性变更。

Screenshots or Test Results / 运行截图或测试结果

修改后的样式:现在常态显示按钮,不再只有hover的时候才展示
image


Checklist / 检查清单

  • 😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
    / 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。

  • 👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
    / 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”

  • 🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in requirements.txt and pyproject.toml.
    / 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到 requirements.txtpyproject.toml 文件相应位置。

  • 😮 My changes do not introduce malicious code.
    / 我的更改没有引入恶意代码。

Summary by Sourcery

Enhancements:

  • Update OutlinedActionListItem styling so action buttons are visible by default rather than hidden until hover.

@auto-assign auto-assign Bot requested review from LIghtJUNction and Soulter May 8, 2026 09:26
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 8, 2026
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • With opacity: 0 removed, the actions are now always visible but pointer-events: none remains, which may still prevent clicks in the default state; double-check whether this should also be updated to allow interaction without hover.
  • The transition: opacity 0.16s ease rule no longer has any effect now that opacity is constant, so consider either reintroducing a state change that uses opacity or removing the transition for clarity.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- With `opacity: 0` removed, the actions are now always visible but `pointer-events: none` remains, which may still prevent clicks in the default state; double-check whether this should also be updated to allow interaction without hover.
- The `transition: opacity 0.16s ease` rule no longer has any effect now that opacity is constant, so consider either reintroducing a state change that uses opacity or removing the transition for clarity.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@dosubot dosubot Bot added the area:webui The bug / feature is about webui(dashboard) of astrbot. label May 8, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the default zero opacity from action list items to make them visible. However, the reviewer pointed out that the items remain non-interactive because pointer-events: none is still applied in the base styles. It is recommended to remove the pointer-events restriction and clean up the now-redundant hover and transition styles to ensure the component functions correctly.

align-items: center;
display: flex;
gap: 4px;
opacity: 0;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

移除 opacity: 0 实现了视觉上的常态显示,但 pointer-events: none; 仍保留在基础样式中,这会导致按钮在非 hover 状态下虽然可见但无法响应点击。为了彻底实现「常态显示」并保证交互正常,建议同时移除 pointer-events: none;transition 属性,并清理后续样式中相关的 :hover:focus-within 冗余规则(如第 125-129 行及 143-146 行)。

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 9, 2026
@RC-CHN RC-CHN merged commit f9cbe79 into AstrBotDevs:master May 9, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:webui The bug / feature is about webui(dashboard) of astrbot. lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants