feat: enable smooth markdown streaming#8371
Merged
Soulter merged 1 commit intoMay 27, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- For the new optional
isStreamingprops, consider providing explicit default values indefineProps(e.g.,isStreaming: { type: Boolean, default: false }) to avoid relying onundefinedcoercion and to clarify intent. - The MarkStream-related attributes (
final,smooth-streaming,fade,typewriter,max-live-nodes) are now duplicated across several components; consider extracting a small wrapper/component or composable to centralize this configuration and keep behavior consistent.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- For the new optional `isStreaming` props, consider providing explicit default values in `defineProps` (e.g., `isStreaming: { type: Boolean, default: false }`) to avoid relying on `undefined` coercion and to clarify intent.
- The MarkStream-related attributes (`final`, `smooth-streaming`, `fade`, `typewriter`, `max-live-nodes`) are now duplicated across several components; consider extracting a small wrapper/component or composable to centralize this configuration and keep behavior consistent.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates several markdown and streaming-related dependencies in package.json and pnpm-lock.yaml, notably upgrading markstream-vue to 1.0.1-beta.1 and stream-markdown to ^0.0.15. It also introduces the is-streaming prop across various chat components (such as ChatMessageList.vue, MessageList.vue, and MarkdownMessagePart.vue) to conditionally enable smooth streaming, fade, and final rendering configurations. There are no review comments to address, so I have no additional feedback to provide.
Soulter
approved these changes
May 27, 2026
Member
|
thanks, markstream-vue is a very impressive work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifications / 改动点
Screenshots or Test Results / 运行截图或测试结果
Checklist / 检查清单
😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
/ 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。
👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
/ 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”。
🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in
requirements.txtandpyproject.toml./ 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到
requirements.txt和pyproject.toml文件相应位置。😮 My changes do not introduce malicious code.
/ 我的更改没有引入恶意代码。
Summary by Sourcery
Enable smooth streaming-aware markdown rendering for chat messages and reasoning content and update related streaming dependencies.
New Features:
Enhancements: