Fixed #8546 and also fixed #8552#8590
Conversation
dosubot
Bot
added
size:M
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 2 issues, and left some high level feedback:
- In
step,_simple_print_message_rolenow always logsself.run_context.messages, so the[BefCompact]and[AftCompact]logs will be identical; consider passing/using the provider-processed_provider_messagesfor the post-compaction log so the debug output actually reflects the transformation. - The tool call filtering in
stepbuildsvalid_indicesfromzip(llm_resp.tools_call_name, llm_resp.tools_call_ids)but then indexes intollm_resp.tools_call_argsusing those indices; iftools_call_argsis shorter thantools_call_name/tools_call_ids, this will raiseIndexError, so it would be safer to derive indices from zipping all three lists or clamp to the minimum length. - The new
_should_fix_modalities_for_provideronly treats a non-emptylistas a configured modalities value, whereas previously any truthy value (including non-lists) triggered sanitization; if there are providers with non-listmodalitiesconfigs, this silently changes behavior, so consider either validating/normalizingmodalitiesto a list or preserving the old truthiness semantics.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `step`, `_simple_print_message_role` now always logs `self.run_context.messages`, so the `[BefCompact]` and `[AftCompact]` logs will be identical; consider passing/using the provider-processed `_provider_messages` for the post-compaction log so the debug output actually reflects the transformation.
- The tool call filtering in `step` builds `valid_indices` from `zip(llm_resp.tools_call_name, llm_resp.tools_call_ids)` but then indexes into `llm_resp.tools_call_args` using those indices; if `tools_call_args` is shorter than `tools_call_name`/`tools_call_ids`, this will raise `IndexError`, so it would be safer to derive indices from zipping all three lists or clamp to the minimum length.
- The new `_should_fix_modalities_for_provider` only treats a non-empty `list` as a configured modalities value, whereas previously any truthy value (including non-lists) triggered sanitization; if there are providers with non-list `modalities` configs, this silently changes behavior, so consider either validating/normalizing `modalities` to a list or preserving the old truthiness semantics.
## Individual Comments
### Comment 1
<location path="astrbot/core/agent/runners/tool_loop_agent_runner.py" line_range="596-598" />
<code_context>
log_context_sanitize_stats(stats)
return sanitized_contexts
+ def _should_fix_modalities_for_provider(self) -> bool:
+ modalities = self.provider.provider_config.get("modalities", None)
+ return (
+ isinstance(modalities, list) and modalities
+ ) # Empty list is treated as unconfigured
</code_context>
<issue_to_address>
**suggestion (bug_risk):** The new modalities check only supports non-empty `list` values and will skip sanitization for other sequence types.
This narrows the definition of “configured” from any truthy value to only a non-empty `list`. If a provider config uses another sequence type (e.g. a tuple), sanitization will now silently stop applying. If that’s intended, consider normalizing `modalities` to a list earlier; otherwise, widen the check to accept other iterable sequence types (or coerce to `list`) so the previous behavior is preserved while still treating `None`/`[]` as unconfigured.
Suggested implementation:
```python
def _should_fix_modalities_for_provider(self) -> bool:
modalities = self.provider.provider_config.get("modalities", None)
# Treat None and empty sequences (e.g. [], (), etc.) as "unconfigured".
# For non-sequence types, preserve the previous "truthy means configured" behavior.
if modalities is None:
return False
try:
from collections.abc import Sequence # local import to avoid module-level changes if not already present
except ImportError: # very defensive; Sequence should be available in supported Python versions
return bool(modalities)
if isinstance(modalities, Sequence) and not isinstance(modalities, (str, bytes)):
return len(modalities) > 0
return bool(modalities)
```
If `Sequence` is already imported at the module level (e.g. `from collections.abc import Sequence`), you should remove the local import inside `_should_fix_modalities_for_provider` and rely on the existing import instead to keep imports centralized and avoid redundant imports.
</issue_to_address>
### Comment 2
<location path="astrbot/core/agent/runners/tool_loop_agent_runner.py" line_range="905-914" />
<code_context>
parts = None
+
+ # 过滤掉无效的 tool calls，确保 assistant 消息不包含无 id/name 的条目
+ if llm_resp.tools_call_name and llm_resp.tools_call_ids:
+ valid_indices = [
+ i for i, (name, tid) in enumerate(
+ zip(llm_resp.tools_call_name, llm_resp.tools_call_ids)
+ )
+ if name and tid
+ ]
+ if len(valid_indices) < len(llm_resp.tools_call_name):
+ llm_resp.tools_call_name = [llm_resp.tools_call_name[i] for i in valid_indices]
+ llm_resp.tools_call_args = [llm_resp.tools_call_args[i] for i in valid_indices]
+ llm_resp.tools_call_ids = [llm_resp.tools_call_ids[i] for i in valid_indices]
+
+ # 如果过滤后没有有效的 tool calls，跳过构建 tool_calls_result
</code_context>
<issue_to_address>
**issue (bug_risk):** Filtering tool calls by index assumes `tools_call_args` is at least as long as `tools_call_name`/`tools_call_ids`, which may raise `IndexError` on malformed provider output.
`valid_indices` comes from `zip(tools_call_name, tools_call_ids)`, but is then applied to `tools_call_args` without verifying that `tools_call_args` is at least as long. If a provider returns fewer args than names/ids, indexing `tools_call_args[i]` will raise `IndexError`. To avoid this, build the filtered lists in a single pass over `zip(tools_call_name, tools_call_args, tools_call_ids)` and append only fully valid triples, or use `zip_longest` with explicit handling of missing values.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the tool loop agent runner to prevent mutating canonical messages during compaction, updates the LLM compressor parameters, and adds filtering to skip invalid tool calls with missing names or IDs. The review feedback highlights several critical issues: a parameter renaming mismatch that will cause an AttributeError in ContextManager, potential IndexError exceptions when accessing tool call names and arguments without bounds checks, and a type annotation mismatch where a method returns a list instead of a boolean.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
dosubot
Bot
added
size:L
效果如上 测一下 这次变更较为重要
|
|
首先，提交pr符合社区规范按照模板，不要起这种不知所云的标题。其次请原子化提交而不是把所有功能的修复和改动放到一个pr里。还有，配置证书和ssl这种事放在bot本体里会使得功能冗余，不适合作为一个feature放进来，这种事应该让nginx或者caddy来干。还有就是有很多无意义的改动。我将关闭这个pr，如果你愿意重新提交，请遵循社区规范使用模板，谢谢。 |
首先 你只会看标题 不会看git commit -m "这里的字面量" |
很明显我好好说的的建议你一个也没听进去，那我们也没讨论的必要了 |
|
继续保持健康模式为true吧,真健康... |
很明显我每个都听了 听不进去你想想自己的问题 现在标题改了 |
对贡献者一点基本的尊重和礼貌都没有，你的礼仪去哪了呢？？？你有没有去了解过设计出健康模式的意图在哪里？适配器平台的位置改动是何意味？pr2个无意义的功能改动，这不是你的项目ok？别在开源社区里乱叫。 |
你自己一点教养没有，社区要求不遵守，连最基本的标题都不会写，每一句话都透露着你骨子里的那股自负的酸臭味 |
竟然还有自我介绍 |
我永远不会和一个纯傻逼对骂 因为它会把我的智商拉到和它一个等级 然后用它当了多年傻逼的丰富经验击败我 |
你对别人的攻击真的是很精辟的符合了你自身的形象 |
一路走好哦，最好再也别回来了 |
|
AstrBot 是多平台项目，而你的 |
|
前3个修改可以。自动申请Lets encrypt的免费证书可以交给另外项目来完成，Astrbot不适合支持。后面的“Telegram适配器位置改到最前面”“最大步数改成114514”是合意味？如果你是想豪到我那你赢了 |
|
感觉大家都在骂他的为人，骂他的语气， 骂他没有按照规范写描述，但就是没有人仔细看看他的pr和issue，其实你要是仔细看看的话，你就会发现...你其实骂轻了 |
|
轻松绷住 |
|
合影留念（这期神完了，豪死我了） |
|
|
大多更改其实只是你不理解规范导致的。 |
|
慕名而来，你也真是无敌了。其他的不说你什么，但是那个改成114514和把Telegram挪到最前面是何意味，有点像是你想意淫想改所以就改出来的东西，压根就没有实际意义。也压根根本没有考虑到广大astrBot大部分人的用户使用场景，还搁这儿说别人呢，你就别在这里发癫了，提交pr申请的时候做不到最基础的礼貌这个尊重，哪怕你提交这些东西是有进步的，是对的， 也不会有人尊重你的，因为是你提前不尊重别人，更何况你交的还是这一坨。 |
|
你已急哭 |
|
项目里放木马的来了 |
|
|
|
慕名而来，震撼首发，合影喵！ 其实其他人都说的很详细了，我着重说一下最令人昏厥的一点： 什么叫最大循环轮数为114514？对于正常的用户请求，我敢说没有任何一种情况可以到达这个轮数，那这个上限就是毫无意义的。 30虽然客观上说没有一个比较合理的依据，但是很容易让人理解这样做的目的：限制某些情况下agent调用轮次防止过多的上下文消耗，我知道114514是什么但是很可惜开源项目的源代码不是你玩梗的敌方。 |
|
慕名而来，真被吓哭了，我从来没见过如此逆天的，我的评价是——人类毁灭吧，地球完蛋吧，外星人快来占领吧 |
|
慕名而来 豪到我了 |
|
见证互联网多样性 |
|
慕名而来，114514 是何意味啊？ |
|
请你撤回这个提交 |
|
合影留恋 |
|
大家好，出来遛狗来了 |
|
还有高手，嘉豪翻墙翻出优越感了 |
我超，盒😨 |
|
这事已经传遍我的小群了（逃
可以考虑 DMCA 喵 |
|
合影合影 |
|
慕名而来，合影留念～这期神完了🤣 |
|
慕名而来 |
|
|
恭迎编程圈皇帝莅临astrbot！ |
20 participants
Fixed #8546 and also fixed #8552
Actually,
Fixed Pydantic data validation errors
Added validation for function.name being None and empty tool_call_id issues
In AstrBot/astrbot/core/computer/booters/local.py, a _BLOCKED_COMMAND_PATTERNS list was defined; users can now customize this list
Changed the health mode default to false — major mistake! Accidentally committed cmd_config.json! I won't change this config for now. If other collaborators (not contributors) request it, it can be modified.
After visiting http://X.X.X.X:6185/#/platforms and clicking "Create Bot" then selecting a messaging platform category, Telegram is placed at the very top — far ahead of others.
Regarding step limits and boring prompts (#8549), you can see the maximum step count is currently 30 — this is unreasonable and should be changed to 114514
Automatically apply for free Let's Encrypt SSL certificates, which means you can access it via https://X.X.X.X
修复了 #8546 也修复了 #8552