Skip to content

Enable full credential autofill on WebUI login form#8631

Merged
Soulter merged 3 commits into
masterfrom
copilot/feature-webui-autocomplete-login
Jun 6, 2026
Merged

Enable full credential autofill on WebUI login form#8631
Soulter merged 3 commits into
masterfrom
copilot/feature-webui-autocomplete-login

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jun 6, 2026

Password managers were only autofilling the password on the WebUI account login stage, leaving username empty. This update adds explicit browser/password-manager autocomplete metadata so both credentials can be populated consistently.

  • What changed

    • Updated dashboard/src/views/authentication/authForms/stages/AuthStageAccount.vue login inputs:
      • username field: autocomplete="username"
      • password field: autocomplete="current-password"
  • Why this matters

    • Aligns the login form with standard credential autofill semantics used by Bitwarden and other password managers.
    • Improves login UX without changing auth flow or validation behavior.
  • Code excerpt

<v-text-field
  :model-value="props.username"
  :label="t('username')"
  autocomplete="username"
  ...
/>

<v-text-field
  :model-value="props.password"
  :label="t('password')"
  autocomplete="current-password"
  :type="showPassword ? 'text' : 'password'"
  ...
/>

Summary by Sourcery

Enable full credential autofill support on the WebUI login form and adjust pnpm workspace build configuration.

New Features:

  • Support browser and password manager autofill for both username and password on the WebUI login form.

Build:

  • Introduce a pnpm workspace configuration enabling builds for esbuild and vue-demi.

Copilot AI linked an issue Jun 6, 2026 that may be closed by this pull request
2 tasks
Copilot AI changed the title [WIP] Add autocomplete for username in webui login form Enable full credential autofill on WebUI login form Jun 6, 2026
Copilot AI requested a review from Soulter June 6, 2026 15:14
@Soulter Soulter marked this pull request as ready for review June 6, 2026 15:16
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. area:webui The bug / feature is about webui(dashboard) of astrbot. labels Jun 6, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jun 6, 2026
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The new pnpm-workspace.yaml file changes the workspace behavior globally; please confirm this belongs in this PR and that enabling builds for esbuild and vue-demi won’t have unintended side effects for other packages in the monorepo.
  • Now that autocomplete is set for the main login fields, consider checking other authentication-related forms/components (e.g., registration, password reset, secondary login flows) for consistent and explicit autocomplete metadata.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The new `pnpm-workspace.yaml` file changes the workspace behavior globally; please confirm this belongs in this PR and that enabling builds for `esbuild` and `vue-demi` won’t have unintended side effects for other packages in the monorepo.
- Now that `autocomplete` is set for the main login fields, consider checking other authentication-related forms/components (e.g., registration, password reset, secondary login flows) for consistent and explicit autocomplete metadata.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Soulter Soulter merged commit 6ae103a into master Jun 6, 2026
1 check passed
@Soulter Soulter deleted the copilot/feature-webui-autocomplete-login branch June 6, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:webui The bug / feature is about webui(dashboard) of astrbot. lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] webui登录界面登录信息自动填充

2 participants