Enable full credential autofill on WebUI login form#8631
Merged
Conversation
2 tasks
Copilot
AI
changed the title
[WIP] Add autocomplete for username in webui login form
Enable full credential autofill on WebUI login form
Jun 6, 2026
Soulter
approved these changes
Jun 6, 2026
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new
pnpm-workspace.yamlfile changes the workspace behavior globally; please confirm this belongs in this PR and that enabling builds foresbuildandvue-demiwon’t have unintended side effects for other packages in the monorepo. - Now that
autocompleteis set for the main login fields, consider checking other authentication-related forms/components (e.g., registration, password reset, secondary login flows) for consistent and explicit autocomplete metadata.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new `pnpm-workspace.yaml` file changes the workspace behavior globally; please confirm this belongs in this PR and that enabling builds for `esbuild` and `vue-demi` won’t have unintended side effects for other packages in the monorepo.
- Now that `autocomplete` is set for the main login fields, consider checking other authentication-related forms/components (e.g., registration, password reset, secondary login flows) for consistent and explicit autocomplete metadata.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Password managers were only autofilling the password on the WebUI account login stage, leaving username empty. This update adds explicit browser/password-manager autocomplete metadata so both credentials can be populated consistently.
What changed
dashboard/src/views/authentication/authForms/stages/AuthStageAccount.vuelogin inputs:autocomplete="username"autocomplete="current-password"Why this matters
Code excerpt
Summary by Sourcery
Enable full credential autofill support on the WebUI login form and adjust pnpm workspace build configuration.
New Features:
Build: