Skip to content

perf: increase weixin http api request timeout from 15s to 120s#8643

Merged
Soulter merged 1 commit into
masterfrom
perf/weixin
Jun 7, 2026
Merged

perf: increase weixin http api request timeout from 15s to 120s#8643
Soulter merged 1 commit into
masterfrom
perf/weixin

Conversation

@Soulter
Copy link
Copy Markdown
Member

@Soulter Soulter commented Jun 7, 2026

Modifications / 改动点

  • This is NOT a breaking change. / 这不是一个破坏性变更。

Screenshots or Test Results / 运行截图或测试结果


Checklist / 检查清单

  • 😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
    / 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。

  • 👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
    / 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”

  • 🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in requirements.txt and pyproject.toml.
    / 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到 requirements.txtpyproject.toml 文件相应位置。

  • 😮 My changes do not introduce malicious code.
    / 我的更改没有引入恶意代码。

Summary by Sourcery

Enhancements:

  • Raise the configured Weixin OC HTTP API timeout from 15 seconds to 120 seconds in both default settings and adapter initialization to improve robustness in slow network environments.

@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. area:platform The bug / feature is about IM platform adapter, such as QQ, Lark, Telegram, WebChat and so on. labels Jun 7, 2026
@Soulter Soulter merged commit 66a10c0 into master Jun 7, 2026
20 checks passed
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request increases the default API timeout for the WeChat Official Account (weixin_oc) integration from 15 seconds (15,000 ms) to 2 minutes (120,000 ms) in both the default configuration and the adapter. There are no review comments, and the changes look correct, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The default timeout value 120_000 is now duplicated in both the default config and the adapter; consider centralizing this as a single constant or deriving the adapter fallback from the config to avoid divergence in future changes.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The default timeout value `120_000` is now duplicated in both the default config and the adapter; consider centralizing this as a single constant or deriving the adapter fallback from the config to avoid divergence in future changes.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Soulter Soulter deleted the perf/weixin branch June 7, 2026 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:platform The bug / feature is about IM platform adapter, such as QQ, Lark, Telegram, WebChat and so on. size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant