Handle Anthropic usage=None on content-filtered responses#8647
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix AttributeError when content_filter causes usage to be None
Handle Anthropic Jun 7, 2026
usage=None on content-filtered responses
Soulter
approved these changes
Jun 7, 2026
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In the new test,
monkeypatch.setattr(anthropic_source, "Message", _FakeMessage)appears unused sinceprovider.client.messages.createis directly patched to return_FakeMessage; consider removing this monkeypatch to keep the test focused and avoid confusion.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In the new test, `monkeypatch.setattr(anthropic_source, "Message", _FakeMessage)` appears unused since `provider.client.messages.create` is directly patched to return `_FakeMessage`; consider removing this monkeypatch to keep the test focused and avoid confusion.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Anthropic-compatible providers can return
stop_reason=content_filterwithcompletion.usage=None. The non-stream query path assumed usage was always present and could crash withAttributeErrorwhen extracting token counters.Usage extraction hardening
ProviderAnthropic._extract_usageto acceptUsage | None.TokenUsagewhen usage is missing.or 0to keep token accounting safe.Regression coverage for filtered responses
tests/test_anthropic_kimi_code_provider.pyfor content-filtered completions withusage=None.Summary by Sourcery
Handle Anthropic-compatible content-filtered responses that may omit usage data and ensure token accounting remains safe.
Bug Fixes:
Tests: