fix(ui): render ready question marker in timeline#1406
Conversation
|
Warning Review limit reached
More reviews will be available in 46 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Fixes a directly reported question sequencing regression with no separate issue: the question dock could appear while the timeline still lacked a visible handoff marker for the running question.
Why
The dock intentionally appears only after
externalResultReady === true, but the timeline grouping layer originally filtered every pending or runningquestiontool. The first fix allowed ready running questions to render, and this follow-up keeps that marker visible even when it follows a normal tool: ready running questions now split into their own single trow instead of being hidden inside a default-collapsed multi-tool trow.Related Issue
None. This PR follows a direct maintainer report in Codex.
Human Review Status
Approved by @Astro-Han
Review Focus
renderable()still keeps legacy pending and unready running questions hidden, but allows running questions withmetadata.externalResultReady === trueto reach the existing inline marker renderer.groupParts()now cuts a ready running question into its own trow, so the single-row auto-open path makes the marker visible without expanding unrelated tool details.session-trowsnap case exercises the productionAssistantParts -> groupParts -> ToolPartDisplaypath with a normal tool immediately before the ready question marker.Risk Notes
No platform, persistence, dependency, permission, or migration surface is touched. This is a visible UI sequencing fix only.
How To Verify
Screenshots or Recordings
bun run snap session-trowgenerated the local grid atdocs/design/preview/screenshots/session-trow.png; theready-question-markertile was reviewed after the run.Checklist
bug,enhancement,task,documentation. Type labels are author-added; the labeler bot does NOT assign them. Add the label in the GitHub UI, then tick this.app,ui,platform,harness,ci. The labeler bot assigns these on PR open based on changed paths. Confirm the bot's choice (or override if wrong), then tick this.P0,P1,P2,P3. The priority-triage bot suggests one on PR open. Confirm or override, then tick this.Pending,Approved by @<reviewer>, orNot required: <reason>(default isPending; "not required" is restricted to bot-authored low-risk PRs).dev, and my PR title and commit messages use Conventional Commits in English.