Skip to content

fix(ui): render ready question marker in timeline#1406

Merged
Astro-Han merged 2 commits into
devfrom
codex/question-marker-ready
Jun 20, 2026
Merged

fix(ui): render ready question marker in timeline#1406
Astro-Han merged 2 commits into
devfrom
codex/question-marker-ready

Conversation

@Astro-Han

@Astro-Han Astro-Han commented Jun 19, 2026

Copy link
Copy Markdown
Owner

Summary

Fixes a directly reported question sequencing regression with no separate issue: the question dock could appear while the timeline still lacked a visible handoff marker for the running question.

Why

The dock intentionally appears only after externalResultReady === true, but the timeline grouping layer originally filtered every pending or running question tool. The first fix allowed ready running questions to render, and this follow-up keeps that marker visible even when it follows a normal tool: ready running questions now split into their own single trow instead of being hidden inside a default-collapsed multi-tool trow.

Related Issue

None. This PR follows a direct maintainer report in Codex.

Human Review Status

Approved by @Astro-Han

Review Focus

  • renderable() still keeps legacy pending and unready running questions hidden, but allows running questions with metadata.externalResultReady === true to reach the existing inline marker renderer.
  • groupParts() now cuts a ready running question into its own trow, so the single-row auto-open path makes the marker visible without expanding unrelated tool details.
  • The session-trow snap case exercises the production AssistantParts -> groupParts -> ToolPartDisplay path with a normal tool immediately before the ready question marker.

Risk Notes

No platform, persistence, dependency, permission, or migration surface is touched. This is a visible UI sequencing fix only.

How To Verify

Regression RED: packages/ui grouping test failed before the follow-up because the ready question still shared trow:t1 refs with the previous tool.
Diff check: git diff --check passed with no whitespace errors.
UI unit tests: packages/ui message-part grouping/tool/stale focused tests passed, 26 passed.
UI typecheck: cd packages/ui && bun run typecheck passed.
Dock predicate tests: cd packages/app && bun test --preload ./happydom.ts src/pages/session/blockers/use-session-blockers.test.ts passed, 14 passed.
App typecheck: cd packages/app && bun run typecheck passed.
Visual snap: bun run snap session-trow passed, including a normal tool immediately before the ready-question-marker case and a visible marker assertion.
Manual visual review: reviewed docs/design/preview/screenshots/session-trow.png and confirmed the ready-question-marker tile shows the preceding tool row plus the visible inline pending-question marker.

Screenshots or Recordings

bun run snap session-trow generated the local grid at docs/design/preview/screenshots/session-trow.png; the ready-question-marker tile was reviewed after the run.

Checklist

How to use this checklist:

  • Tick a box by replacing [ ] with [x]. Do not edit, add, or remove items.
  • The bot-applied label items can only be honestly ticked AFTER the PR is opened and the labeler / priority-triage bots have run — return to the PR description and tick them then.
  • Most items are required. The few that are conditional are explicitly marked (conditional); for those, leave unticked if they truly do not apply and explain why in Risk Notes. All other items must be ticked before requesting human review.
  • Type label — this PR carries exactly one of bug, enhancement, task, documentation. Type labels are author-added; the labeler bot does NOT assign them. Add the label in the GitHub UI, then tick this.
  • Routing labels — this PR carries at least one of app, ui, platform, harness, ci. The labeler bot assigns these on PR open based on changed paths. Confirm the bot's choice (or override if wrong), then tick this.
  • Priority label — this PR carries exactly one of P0, P1, P2, P3. The priority-triage bot suggests one on PR open. Confirm or override, then tick this.
  • Human Review Status above is set to Pending, Approved by @<reviewer>, or Not required: <reason> (default is Pending; "not required" is restricted to bot-authored low-risk PRs).
  • I linked the related issue, or stated in Summary why there is no issue.
  • I described the review focus and any meaningful risks.
  • I replaced the example block in How To Verify with the real verification steps and the key result for each.
  • I did not introduce unrelated refactors, dependencies, generated files, or file changes beyond the stated scope.
  • (conditional) I manually checked visible UI or copy changes when needed, with screenshots or recordings. Leave unticked only if no visible UI or copy changed.
  • (conditional) I considered macOS and Windows impact for platform, packaging, updater, signing, paths, shell, or permissions changes. Leave unticked only if no platform/packaging surface was touched.
  • (conditional) I called out docs, release notes, dependencies, permissions, credentials, deletion behavior, generated content, or local file changes when relevant. Leave unticked only if none of those surfaces was touched.
  • I reviewed the final diff for unrelated changes and suspicious dependency changes.
  • I am targeting dev, and my PR title and commit messages use Conventional Commits in English.

@Astro-Han Astro-Han added bug Something isn't working P2 Medium priority ui Design system and user interface labels Jun 19, 2026
@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@Astro-Han, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 46 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: aca5fafd-d1d6-4e4f-b401-28c98ea9f61a

📥 Commits

Reviewing files that changed from the base of the PR and between a660288 and 0aab4c9.

📒 Files selected for processing (6)
  • packages/app/e2e/snap/fixtures/trow-snap-fixture-data.ts
  • packages/app/e2e/snap/fixtures/trow-snap-fixture.tsx
  • packages/app/e2e/snap/session-trow.snap.ts
  • packages/ui/src/components/message-part-stale.test.ts
  • packages/ui/src/components/message-part/grouping.test.ts
  • packages/ui/src/components/message-part/grouping.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/question-marker-ready

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the app Application behavior and product flows label Jun 19, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested priority: P2 (includes non-doc, non-test paths outside the low-risk bucket).

P1/P0 are reserved for maintainer confirmation. Please relabel manually if this is a release blocker, security issue, data-loss risk, or updater/runtime failure.

@Astro-Han Astro-Han merged commit 420edee into dev Jun 20, 2026
45 checks passed
@Astro-Han Astro-Han deleted the codex/question-marker-ready branch June 20, 2026 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app Application behavior and product flows bug Something isn't working P2 Medium priority ui Design system and user interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant