fix(skill): allow missing descriptions#665
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe ChangesOptional skill description filtering
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request makes the description field optional for skills and ensures that skills without descriptions are excluded from formatted output. Key changes include updating the Zod schema and generated TypeScript types, modifying the fmt function to filter out undescribed skills, and adding comprehensive tests to verify this behavior. I have no feedback to provide.
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Summary
Allow skill frontmatter to omit
descriptionwhile still loading the skill, and keep description-less skills out of automatic skill prompt listings.Why
This absorbs the still-relevant part of upstream
opencodestability follow-upanomalyco/opencode#26391for #512. Before this change, PawWork skipped otherwise valid skills when the skill only had aname; after this change, those skills remain available for direct loading without being advertised as auto-matchable skills.Related Issue
Closes #512 for the
anomalyco/opencode#26391slice only. Other #512 candidates were checked separately: deterministic tool ordering, npm shim signal forwarding, and shell carriage-return normalization are already covered locally; the network-options AppRuntime follow-up remains a separate possible slice.Human Review Status
Pending. A human should make the final merge decision after reviewing the final diff and verification evidence.
Review Focus
Please check that the behavior boundary is right: description-less skills should load through the skill registry/API, but should not appear in formatted automatic skill prompt lists.
Risk Notes
Low. This changes skill metadata shape from required to optional and updates the generated SDK response type. It does not touch UI, desktop packaging, runtime process behavior, or onboarding.
How To Verify
Screenshots or Recordings
N/A. No visible UI changes.
Checklist
dev, and my PR title and commit messages use Conventional Commits in EnglishSummary by CodeRabbit