Visual selection moving lines of more than 3 lines does not keep selection

[tuero]

Checklist

• Using a stable version of Neovim (i.e. not neovim nightly)
• :AstroUpdate
• Restarted AstroNvim

Operating system/version

Ubuntu 22.10

Terminal/GUI

Windows terminal

AstroNvim Health

==============================================================================
astronvim: require("astronvim.health").check()

AstroNvim ~

• AstroNvim Version: v3.11.1
• Neovim Version: v0.9.0
• OK Using stable Neovim >= 0.8.0
• OK git is installed: Used for core functionality such as updater and plugin management
• OK xdg-open is installed: Used for gx mapping for opening files with system opener (Optional)
• WARNING lazygit is not installed: Used for mappings to pull up git TUI (Optional)
• OK node is installed: Used for mappings to pull up node REPL (Optional)
• WARNING gdu is not installed: Used for mappings to pull up disk usage analyzer (Optional)
• WARNING btm is not installed: Used for mappings to pull up system monitor (Optional)
• OK python is installed: Used for mappings to pull up python REPL (Optional)

Describe the bug

When trying to move a selection of more than 3 lines and keeping the selection after the move, the lines are moved but the selection does not keep. I've provided a screen grab from someone in the discord server showing this behaviour. It works for a selection of 2 lines, but not 3 or more.

The keybind in user/mappings.lua is

v = {
    ["<A-k>"] = {":m '<-2<CR>gv=gv", desc = "move line up"},
    ["<A-j>"] = {":m '>+1<CR>gv=gv", desc = "move line down"},
  },

I've confirmed these keybinds (:vnoremap <A-k> :m '<-2<CR>gv=gv) work when no configuration is loaded nvim --clean. It also works with 2 lines selected, but no more than that.

Steps to Reproduce

1. Clean install of astrovim
2. Use the following keymappings or :vnoremap <A-k> :m '<-2<CR>gv=gv
3. Try to move a selection of 3 or more lines

Expected behavior

A selection of more than 3 lines should move and keep the selection, similar to the behaviour of using 2 lines.

Screenshots

Screenshare_-_2023-05-16_1_54_52_PM.mp4

Additional Context

No response

[mehalter]

This is being caused by enabling copyindent by default which is a built in Vim/Neovim option. It looks like your mapping you are using is not compatible with this mode. I am going to go ahead and remove this default on nightly. If you want to fix your mapping before the next release is tagged then you can add copyindent = false to your options.opt table.

I am also going to go ahead and close this since it's not really a bug in AstroNvim and just incompatibility with your mapping and a core vim feature that we happen to be using.

[tuero]

Thanks, I didn't realize this setting had implications with the movements.

[tuero]

Sorry, but I just got around to testing this. I removed all previous configurations/cache, cloned a new astrovim config, set opt.copyindent=false, then tried setting :vnoremap <A-k> :m '<-2<CR>gv=gv and I still get the same behaviour. Am I missing something in terms of the fix?

[mehalter]

I misspoke here! Sorry about that! It is actually cmdheight = 0 causing the issue. Not sure what that interaction has to do with anything, but that is sadly not something I am going to be changing as a default. You could look into plugins such as mini.move instead of making your own mappings

[tuero]

Ah thanks, setting cmdheight=1 does indeed fix the issue. Keeping with 0 prevents other plugins from working as well, but that's ok as I'm willing to have it set to 1 in my personal config.