Skip to content

Conversation

@Uzaaft
Copy link
Member

@Uzaaft Uzaaft commented Mar 29, 2025

Might be useful for our nix users

@github-actions
Copy link

github-actions bot commented Mar 29, 2025

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

Copy link
Contributor

@azdanov azdanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea what it does, but looks good 😄

@Uzaaft Uzaaft changed the title feat: add in flake for development, and ignore direnv folder feat(build): add in nix devShell, and ignore direnv Mar 31, 2025
@Uzaaft
Copy link
Member Author

Uzaaft commented Mar 31, 2025

gotta need chadhalter @mehalter do merge.(Btw, can I add additional groups/scopes to the pre-commit check?)

@mehalter mehalter changed the title feat(build): add in nix devShell, and ignore direnv ci(main): add in nix devShell, and ignore direnv Mar 31, 2025
@mehalter mehalter changed the title ci(main): add in nix devShell, and ignore direnv build: add in nix devShell, and ignore direnv Apr 3, 2025
@mehalter mehalter merged commit d8fe124 into main Apr 3, 2025
28 of 32 checks passed
@mehalter mehalter deleted the feat/nix-flake branch April 3, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants