Skip to content

Conversation

@Kamilcuk
Copy link
Contributor

@Kamilcuk Kamilcuk commented Apr 1, 2025

📑 Description

Add blink-cmp-tmux

ℹ Additional Information

moving to blink

@github-actions
Copy link

github-actions bot commented Apr 1, 2025

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

@mehalter mehalter merged commit 609389c into AstroNvim:main Apr 3, 2025
16 checks passed
@Kamilcuk
Copy link
Contributor Author

Kamilcuk commented Apr 3, 2025

Hi, wow, the default = { "tmux" } does not replace the list, instead appends. How is the merging done? This is some code in Lazy? Thanks.

@mehalter
Copy link
Member

mehalter commented Apr 3, 2025

lazy.nvim has a feature where opts keys can be specified as a key that should be extended rather than merged which we use for blink.cmp's sources.default key

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants