Skip to content

Conversation

@omagarwal25
Copy link
Contributor

Added Fyler based on a conversation on the discord. Happy to hear recommendations about the keymapping though, I just put it as <Leader>y for now, but there's likely something that makes more sense.

@github-actions
Copy link

github-actions bot commented Jun 13, 2025

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@Uzaaft Uzaaft marked this pull request as ready for review June 14, 2025 07:42
@Uzaaft
Copy link
Member

Uzaaft commented Jun 14, 2025

LGTM. Anything missing? @omagarwal25

@omagarwal25
Copy link
Contributor Author

Was wondering if anyone had a better idea than <Leader>y

@Uzaaft
Copy link
Member

Uzaaft commented Jun 14, 2025

keybinds are hard. No need to perfect that on the first try.

I got oil on Tab and like that even if the Oil plugin has o.

@omagarwal25
Copy link
Contributor Author

Alright, LGTM then!

@Uzaaft
Copy link
Member

Uzaaft commented Jun 14, 2025

@omagarwal25 Can you test this after the last one line change I added and see if it breaks anything.

Besides that, ready to go :)

@Uzaaft Uzaaft merged commit 27e9c1f into AstroNvim:main Jun 16, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants