Skip to content

fix logic to return True when the date_retrieved file is empty #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hyphaltip wants to merge 1 commit into from
Closed

fix logic to return True when the date_retrieved file is empty #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion bin/gtt-get-ncbi-assembly-tables
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ def check_if_data_present_and_less_than_4_weeks_old(location):

# if both files are present (and not empty), we are checking if it was downloaded more than 4 weeks ago
# and will download if it was
if os.path.isfile(table_path) and os.path.isfile(date_retrieved_path):
if os.path.isfile(table_path) and os.path.isfile(date_retrieved_path) and os.path.getsize(date_retrieved_path) > 0:

# getting current date
curr_date = date.today()
Expand All @@ -111,6 +111,8 @@ def check_if_data_present_and_less_than_4_weeks_old(location):

# setting to date object
stored_date_list = stored_date.split(",")
if stored_date_list[0] == ",":
return(True) # the file is actually empty
stored_date = date(int(stored_date_list[0]), int(stored_date_list[1]), int(stored_date_list[2]))

# getting difference
Expand Down