Skip to content

Added Basic Python Projects #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 4, 2021
Merged

Added Basic Python Projects #298

merged 5 commits into from
Oct 4, 2021

Conversation

@ssahibsingh
Copy link
Contributor

@ssahibsingh ssahibsingh commented Oct 4, 2021 •
edited
Loading

I have added Some basic Python Projects.
Issue No. #52

@ssahibsingh ssahibsingh changed the title Added Basic Python Project PhoneNumberDetailsUsingPython.ipynb Added Basic Python Projects Oct 4, 2021
@ssahibsingh ssahibsingh marked this pull request as ready for review October 4, 2021 05:45
@ssahibsingh ssahibsingh mentioned this pull request Oct 4, 2021
Closed
@Astrodevil
Copy link
Owner

Astrodevil commented Oct 4, 2021 •
edited
Loading

@siphyshu Will you please review and instruct this or other PR related to python projects to be added in project or utilities folder.

@Astrodevil Astrodevil linked an issue Oct 4, 2021 that may be closed by this pull request
Want to add some cool small/basic Python Projects. #52
Closed
@Astrodevil Astrodevil added hacktoberfest-accepted used for hacktoberfest 2021 need-review labels Oct 4, 2021
@siphyshu
Copy link
Contributor

siphyshu commented Oct 4, 2021

@siphyshu Will you please review and instruct this or other PR related to python projects to be added in project or utilities folder.

Okay, I will review this PR now, and other ones later when I get time.

@siphyshu
Copy link
Contributor

siphyshu commented Oct 4, 2021

Hey @ssahibsingh,
These would be better suitable under the Python/Utility/ category, so please move it there.
Also add a .py script along with the .ipynb notebooks for each of the utilities.

You can look into taking an arguement from the command line for Phone Number Details script using sys.argv

@ssahibsingh
Updated Basic Python Projects
4b829b6 
Following Changes are made:
1. Moved all Projects to Utility Folder.
2. Added .py scripts along with .ipynb.
3. Updated Phone number detail project.
@ssahibsingh
Copy link
Contributor Author

ssahibsingh commented Oct 4, 2021

@siphyshu I have made all desired changes. Now, Take a look.

@siphyshu
Copy link
Contributor

siphyshu commented Oct 4, 2021

@siphyshu I have made all desired changes. Now, Take a look.

Perfect! @Astrodevil ready for merge.

@Astrodevil Astrodevil merged commit e73c448 into Astrodevil:main Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

hacktoberfest-accepted used for hacktoberfest 2021

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Want to add some cool small/basic Python Projects.

3 participants

@ssahibsingh @Astrodevil @siphyshu