Translated columns sets to null values while using Query Builder

[mshukurlu]

Describe the bug
I am making a Query with Joins . When I want to response translated columns in API they converting to null values.When I hide $translatedAttributes in the model everything works well. Or selecting the columns with an alias for example name as n it returns the value.
To Reproduce
My Database Schema
pages table:

Schema::create('pages', function (Blueprint $table) {
          $table->bigIncrements('id');
          $table->string('slug');
          $table->integer('status');
           $table->string('type')->nullable();
          $table->timestamps();
      });

page_translations table:

   Schema::create('page_translations', function (Blueprint $table) {
            $table->bigIncrements('id');
            $table->bigInteger('page_id')->unsigned()->index();
            $table->foreign('page_id')->references('id')->on('pages')->onDelete('cascade');
            $table->string('locale');
            $table->string('name');
            $table->longText('text');
            $table->timestamps();
        });

My Page Model:

class Page extends Model
{
    use \Astrotomic\Translatable\Translatable;
    
    public $translatedAttributes = ['name','text'];
    protected  $fillable = ['slug','status'];

    public function page_meta()
    {
        return $this->hasMany('App\Models\Page\PageMeta');
    }

    public function getDocumentLinkAttribute()
    {
        return $this->page_meta()->first()->meta_value;
    }
}

PageTranslations model class

PageTranslation extends Model
{
   public $timestamps=false;

   protected $fillable = ['name','text','status'];
}

My codes :

    protected  $pageModel;

    public function __construct(Page $page)
    {
        $this->pageModel = $page;
    }

    public function getApiWithType($type)
    {
        return $this->pageModel->leftJoin('page_translations','pages.id','=','page_translations.page_id')->where('page_translations.locale','az')->where('pages.type','page')->get();
    }

Expected behavior
I am making a Query with Joins. When I want to response translated columns in API they converting to null values.When I hide $translatedAttributes in the model everything works well. Or selecting the columns with an alias for example name as n it returns the true value.

Versions

• PHP: 7.2.11
• Database: Mysql
• Laravel: 5.8
• Package:

[Gummibeer]

Why do you want to join the translations instead of the default behavior? The trait is made to handle all the logic. By joining them your own you make the trait useless and it could create conflicts.
If you have disabled auto-loading you can use the withTranslation() scope.
https://docs.astrotomic.info/laravel-translatable/usage/scopes#withtranslation

laravel-translatable/src/Translatable/Traits/Scopes.php

Lines 109 to 124 in 8ec3841

	public function scopeWithTranslation(Builder $query)
	{
	$query->with([
	'translations' => function (Relation $query) {
	if ($this->useFallback()) {
	$locale = $this->locale();
	$countryFallbackLocale = $this->getFallbackLocale($locale); // e.g. de-DE => de
	$locales = array_unique([$locale, $countryFallbackLocale, $this->getFallbackLocale()]);
	return $query->whereIn($this->getTranslationsTable().'.'.$this->getLocaleKey(), $locales);
	}
	return $query->where($this->getTranslationsTable().'.'.$this->getLocaleKey(), $this->locale());
	},
	]);
	}

[mshukurlu]

@Gummibeer I need to use this like that, I don't need use even translation in this task, If it is possible to deactivate I intend to it in this action, I would use it. Anyway, any package should not affect to another workflow of the application. This is a bug.

[Gummibeer]

You are able to disable the translations on runtime for a specific model.
https://docs.astrotomic.info/laravel-translatable/usage/methods#static-disableautoloadtranslations

laravel-translatable/src/Translatable/Translatable.php

Lines 41 to 44 in 8ec3841

	public static function disableAutoloadTranslations(): void
	{
	self::$autoloadTranslations = false;
	}

I think that the problem relates to the fill(), setAttribute() and/or getAttribute() methods which have problems with the translated attribute from the join.

Anyway, any package should not affect to another workflow of the application.

That is right as long as the workflow doesn't touch the package. The moment your custom workflow interferes the package you can't expect the package to work normal.
That's the contract if you use a package. Every package comes with an intended and official way. Everything besides this could work but don't have to. You can feel free to find a way which allows your code to work without removing an existing functionality and not too much changes.

For completion - this belongs to the same topic like:

• Fallback to actual model value dimsav/laravel-translatable#397
• Usability for a translatable field of a model? dimsav/laravel-translatable#471
• Conditionally enabling translations for models / multi tenancy dimsav/laravel-translatable#537

Having attributes with the same name as a translated attribute on the main model isn't supported and also won't be. That's why I changed the issue from bug to question.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically closed because it has not had recent activity. Thank you for your contributions.

[vahidalvandi]

hello , i need disable translate with bellow model but not work

page::disableAutoloadTranslations();

$rows = pageTranslation::search($request->q)
    ->constrain(
        page::join('site_page_translations', 'site_page.id', 'site_page_translations.page_id')
    )
    ->take(30)
    ->first();